refactor: wip

Author: BioPhoton

packages/utils/src/lib/process-id.unit.test.ts

@@ -1,46 +1,43 @@
-import {
-  WAL_ID_PATTERNS,
-  getUniqueReadableInstanceId,
-  getUniqueRunId,
-} from './process-id.js';
+import { WAL_ID_PATTERNS, getUniqueTimeId } from './process-id.js';
+import { getShardId } from './wal-sharded.js';
 
-describe('getUniqueReadableInstanceId', () => {
+describe('getShardId (formerly getUniqueReadableInstanceId)', () => {
   it('should generate shard ID with readable timestamp', () => {
-    const result = getUniqueReadableInstanceId();
+    const result = getShardId();
 
     expect(result).toMatch(WAL_ID_PATTERNS.INSTANCE_ID);
     expect(result).toStartWith('20231114-221320-000.');
   });
 
   it('should generate different shard IDs for different calls', () => {
-    const result1 = getUniqueReadableInstanceId();
-    const result2 = getUniqueReadableInstanceId();
+    const result1 = getShardId();
+    const result2 = getShardId();
 
     expect(result1).not.toBe(result2);
     expect(result1).toStartWith('20231114-221320-000.');
     expect(result2).toStartWith('20231114-221320-000.');
   });
 
   it('should handle zero values', () => {
-    const result = getUniqueReadableInstanceId();
+    const result = getShardId();
     expect(result).toStartWith('20231114-221320-000.');
   });
 
   it('should handle negative timestamps', () => {
-    const result = getUniqueReadableInstanceId();
+    const result = getShardId();
 
     expect(result).toStartWith('20231114-221320-000.');
   });
 
   it('should handle large timestamps', () => {
-    const result = getUniqueReadableInstanceId();
+    const result = getShardId();
 
     expect(result).toStartWith('20231114-221320-000.');
   });
 
   it('should generate incrementing counter', () => {
-    const result1 = getUniqueReadableInstanceId();
-    const result2 = getUniqueReadableInstanceId();
+    const result1 = getShardId();
+    const result2 = getShardId();
 
     const parts1 = result1.split('.');
     const parts2 = result2.split('.');
@@ -53,18 +50,22 @@ describe('getUniqueReadableInstanceId', () => {
   });
 });
 
-describe('getUniqueRunId', () => {
+describe('getUniqueTimeId (formerly getUniqueRunId)', () => {
   it('should work with mocked timeOrigin', () => {
-    const result = getUniqueRunId();
+    const result = getUniqueTimeId();
 
     expect(result).toBe('20231114-221320-000');
     expect(result).toMatch(WAL_ID_PATTERNS.GROUP_ID);
   });
 
-  it('should be idempotent within same process', () => {
-    const result1 = getUniqueRunId();
-    const result2 = getUniqueRunId();
+  it('should generate new ID on each call (not idempotent)', () => {
+    const result1 = getUniqueTimeId();
+    const result2 = getUniqueTimeId();
 
-    expect(result1).toBe(result2);
+    // Note: getUniqueTimeId is not idempotent - it generates a new ID each call
+    // based on current time, so results will be different
+    expect(result1).toMatch(WAL_ID_PATTERNS.GROUP_ID);
+    expect(result2).toMatch(WAL_ID_PATTERNS.GROUP_ID);
+    // They may be the same if called within the same millisecond, but generally different
   });
 });

packages/utils/src/lib/profiler/__snapshots__/sharded-path-trace-events.jsonl

@@ -1,4 +1,4 @@
-{"cat":"blink.user_timing","ph":"i","name":"write-test:test-operation:start","pid":10001,"tid":1,"ts":1700000005000000,"args":{"detail":"{\"devtools\":{\"track\":\"Test\",\"dataType\":\"track-entry\"}}"}}
-{"cat":"blink.user_timing","ph":"b","name":"write-test:test-operation","id2":{"local":"0x1"},"pid":10001,"tid":1,"ts":1700000005000001,"args":{"data":{"detail":"{\"devtools\":{\"track\":\"Test\",\"dataType\":\"track-entry\"}}"}}}
-{"cat":"blink.user_timing","ph":"e","name":"write-test:test-operation","id2":{"local":"0x1"},"pid":10001,"tid":1,"ts":1700000005000002,"args":{"data":{"detail":"{\"devtools\":{\"track\":\"Test\",\"dataType\":\"track-entry\"}}"}}}
-{"cat":"blink.user_timing","ph":"i","name":"write-test:test-operation:end","pid":10001,"tid":1,"ts":1700000005000003,"args":{"detail":"{\"devtools\":{\"track\":\"Test\",\"dataType\":\"track-entry\"}}"}}
+{"cat":"blink.user_timing","ph":"i","name":"write-test:test-operation:start","pid":10001,"tid":1,"ts":1700000005000000,"args":{"detail":{"devtools":{"track":"Test","dataType":"track-entry"}}}}
+{"cat":"blink.user_timing","ph":"b","name":"write-test:test-operation","id2":{"local":"0x1"},"pid":10001,"tid":1,"ts":1700000005000001,"args":{"data":{"detail":{"devtools":{"track":"Test","dataType":"track-entry"}}}}}
+{"cat":"blink.user_timing","ph":"e","name":"write-test:test-operation","id2":{"local":"0x1"},"pid":10001,"tid":1,"ts":1700000005000002,"args":{"data":{"detail":{"devtools":{"track":"Test","dataType":"track-entry"}}}}}
+{"cat":"blink.user_timing","ph":"i","name":"write-test:test-operation:end","pid":10001,"tid":1,"ts":1700000005000003,"args":{"detail":{"devtools":{"track":"Test","dataType":"track-entry"}}}}