test(utils): create mocks folder, unify mock setup

Tlacenka · Tlacenka · commit 6914578e4b94 · 2024-01-04T18:49:43.000+01:00
diff --git a/packages/cli/vite.config.integration.ts b/packages/cli/vite.config.integration.ts
@@ -12,6 +12,7 @@ export default defineConfig({
     },
     environment: 'node',
     include: ['src/**/*.integration.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
+    globalSetup: ['global-setup.ts'],
     setupFiles: [
       '../../testing-utils/src/lib/setup/console.mock.ts',
       '../../testing-utils/src/lib/setup/reset.mocks.ts',
diff --git a/packages/cli/vite.config.unit.ts b/packages/cli/vite.config.unit.ts
@@ -12,6 +12,7 @@ export default defineConfig({
     },
     environment: 'node',
     include: ['src/**/*.unit.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
+    globalSetup: ['global-setup.ts'],
     setupFiles: [
       '../../testing-utils/src/lib/setup/fs.mock.ts',
       '../../testing-utils/src/lib/setup/console.mock.ts',
diff --git a/packages/core/vite.config.integration.ts b/packages/core/vite.config.integration.ts
@@ -12,6 +12,7 @@ export default defineConfig({
     },
     environment: 'node',
     include: ['src/**/*.integration.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
+    globalSetup: ['global-setup.ts'],
     setupFiles: [
       '../../testing-utils/src/lib/setup/console.mock.ts',
       '../../testing-utils/src/lib/setup/reset.mocks.ts',
diff --git a/packages/core/vite.config.unit.ts b/packages/core/vite.config.unit.ts
@@ -12,6 +12,7 @@ export default defineConfig({
     },
     environment: 'node',
     include: ['src/**/*.unit.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
+    globalSetup: ['global-setup.ts'],
     setupFiles: [
       '../../testing-utils/src/lib/setup/fs.mock.ts',
       '../../testing-utils/src/lib/setup/console.mock.ts',
diff --git a/packages/utils/mocks/fixtures/execute-progress.mock.mjs b/packages/utils/mocks/fixtures/execute-progress.mock.mjs
diff --git a/packages/utils/mocks/fixtures/no-export.mjs b/packages/utils/mocks/fixtures/no-export.mjs
diff --git a/packages/utils/mocks/fixtures/undefined-export.mjs b/packages/utils/mocks/fixtures/undefined-export.mjs
diff --git a/packages/utils/mocks/fixtures/valid-export.mjs b/packages/utils/mocks/fixtures/valid-export.mjs
diff --git a/packages/utils/src/lib/file-system.unit.test.ts b/packages/utils/src/lib/file-system.unit.test.ts
@@ -96,7 +96,7 @@ describe('logMultipleFileResults', () => {
 });
 
 const getFilepath = (fileName: string) =>
-  join(process.cwd(), 'packages', 'utils', 'test', 'fixtures', fileName);
+  join(process.cwd(), 'packages', 'utils', 'mocks', 'fixtures', fileName);
 
 describe('importEsmModule', () => {
   it('should load file', async () => {
diff --git a/packages/utils/test/index.ts b/packages/utils/test/index.ts
diff --git a/packages/utils/tsconfig.lib.json b/packages/utils/tsconfig.lib.json
@@ -11,7 +11,7 @@
     "vite.config.integration.ts",
     "src/**/*.test.ts",
     "src/**/*.mock.ts",
-    "test/**/*.ts",
+    "mocks/**/*.ts",
     "perf/**/*.ts"
   ]
 }
diff --git a/packages/utils/tsconfig.test.json b/packages/utils/tsconfig.test.json
@@ -7,7 +7,7 @@
   "include": [
     "vite.config.unit.ts",
     "vite.config.integration.ts",
-    "test/**/*.ts",
+    "mocks/**/*.ts",
     "src/**/*.test.ts",
     "src/**/*.test.tsx",
     "src/**/*.test.js",
diff --git a/packages/utils/vite.config.integration.ts b/packages/utils/vite.config.integration.ts
@@ -13,5 +13,9 @@ export default defineConfig({
     environment: 'node',
     include: ['src/**/*.integration.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
     globalSetup: ['global-setup.ts'],
+    setupFiles: [
+      '../../testing-utils/src/lib/setup/console.mock.ts',
+      '../../testing-utils/src/lib/setup/reset.mocks.ts',
+    ],
   },
 });
diff --git a/packages/utils/vite.config.unit.ts b/packages/utils/vite.config.unit.ts
@@ -12,6 +12,7 @@ export default defineConfig({
     },
     environment: 'node',
     include: ['src/**/*.unit.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
+    globalSetup: ['global-setup.ts'],
     setupFiles: [
       '../../testing-utils/src/lib/setup/console.mock.ts',
       '../../testing-utils/src/lib/setup/reset.mocks.ts',
diff --git a/testing-utils/src/lib/fixtures/report.mock.ts b/testing-utils/src/lib/fixtures/report.mock.ts
@@ -75,8 +75,24 @@ export const REPORT_MOCK = {
         {
           slug: 'cypress-e2e-tests',
           title: 'Cypress e2e tests',
-          value: 5,
+          value: 3,
           score: 0.5,
+          details: {
+            issues: [
+              {
+                message: 'Test `Display progress for selected commit` failed.',
+                severity: 'error',
+              },
+              {
+                message: 'Test `Sort audit table based on value` failed.',
+                severity: 'error',
+              },
+              {
+                message: 'Test `Open Bug prevention category detail` failed.',
+                severity: 'error',
+              },
+            ],
+          },
         },
         {
           slug: 'cypress-component-tests',
@@ -116,8 +132,38 @@ export const REPORT_MOCK = {
         {
           slug: 'typescript-eslint-typing',
           title: 'Type checking',
-          value: 1,
+          value: 2,
           score: 0,
+          details: {
+            issues: [
+              {
+                message: 'outputFile does not exist in type Cli',
+                severity: 'error',
+                source: {
+                  file: 'packages/cli/cli.ts',
+                  position: {
+                    startLine: 1,
+                    startColumn: 1,
+                    endLine: 5,
+                    endColumn: 10,
+                  },
+                },
+              },
+              {
+                message: 'command might be undefined',
+                severity: 'warning',
+                source: {
+                  file: 'packages/cli/cli.ts',
+                  position: {
+                    startLine: 5,
+                    startColumn: 10,
+                    endLine: 5,
+                    endColumn: 20,
+                  },
+                },
+              },
+            ],
+          },
         },
         {
           slug: 'typescript-eslint-enums',
@@ -130,12 +176,26 @@ export const REPORT_MOCK = {
           title: 'TypeScript experimental checks',
           value: 1,
           score: 0,
+          details: {
+            issues: [{ message: 'Use better-enums.', severity: 'info' }],
+          },
         },
         {
           slug: 'eslint-functional',
           title: 'Functional principles',
           value: 1,
           score: 0,
+          details: {
+            issues: [
+              {
+                message: 'Unexpected let, use const instead.',
+                severity: 'error',
+                source: {
+                  file: 'packages/core/report.ts',
+                },
+              },
+            ],
+          },
         },
         {
           slug: 'eslint-jest-consistent-naming',
diff --git a/testing-utils/src/lib/setup/console.mock.ts b/testing-utils/src/lib/setup/console.mock.ts
@@ -1,17 +1,26 @@
 import { SpyInstance, afterEach, beforeEach, vi } from 'vitest';
 
-let consoleInfoSpy: SpyInstance;
-let consoleWarnSpy: SpyInstance;
-let consoleErrorSpy: SpyInstance;
+let consoleInfoSpy: SpyInstance | undefined;
+let consoleWarnSpy: SpyInstance | undefined;
+let consoleErrorSpy: SpyInstance | undefined;
 
 beforeEach(() => {
-  consoleInfoSpy = vi.spyOn(console, 'info');
-  consoleWarnSpy = vi.spyOn(console, 'warn');
-  consoleErrorSpy = vi.spyOn(console, 'error');
+  // In multi-progress-bars, console methods are overriden
+  if (console.info != null) {
+    consoleInfoSpy = vi.spyOn(console, 'info');
+  }
+
+  if (console.warn != null) {
+    consoleWarnSpy = vi.spyOn(console, 'warn');
+  }
+
+  if (console.error != null) {
+    consoleErrorSpy = vi.spyOn(console, 'error');
+  }
 });
 
 afterEach(() => {
-  consoleInfoSpy.mockRestore();
-  consoleWarnSpy.mockRestore();
-  consoleErrorSpy.mockRestore();
+  consoleInfoSpy?.mockRestore();
+  consoleWarnSpy?.mockRestore();
+  consoleErrorSpy?.mockRestore();
 });
diff --git a/testing-utils/vite.config.unit.ts b/testing-utils/vite.config.unit.ts
@@ -12,6 +12,7 @@ export default defineConfig({
     },
     environment: 'node',
     include: ['src/**/*.unit.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
+    globalSetup: ['global-setup.ts'],
     setupFiles: [
       'src/lib/setup/console.mock.ts',
       'src/lib/setup/reset.mocks.ts',
diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -32,8 +32,7 @@
       "@code-pushup/models/testing": ["packages/models/test/index.ts"],
       "@code-pushup/nx-plugin": ["packages/nx-plugin/src/index.ts"],
       "@code-pushup/testing-utils": ["testing-utils/src/index.ts"],
-      "@code-pushup/utils": ["packages/utils/src/index.ts"],
-      "@code-pushup/utils/testing": ["packages/utils/test/index.ts"]
+      "@code-pushup/utils": ["packages/utils/src/index.ts"]
     }
   },
   "exclude": ["node_modules", "tmp"]
