fix: fix mr comments

Author: AS

eslint.config.js

@@ -28,7 +28,6 @@ export default tseslint.config(
             String.raw`^.*/code-pushup\.(config|preset)(\.m?[jt]s)?$`,
             '^[./]+/tools/.*$',
             '^[./]+/testing/test-vitest-setup/.*$',
-            '^[./]+/test-vitest-setup/.*$',
           ],
           depConstraints: [
             {

packages/cli/vitest.unit.config.ts

@@ -20,13 +20,6 @@ export default defineConfig(() => {
         '../../testing/test-setup/src/lib/reset.mocks.ts',
         '../../testing/test-setup/src/lib/extend/ui-logger.matcher.ts',
       ],
-      coverage: {
-        ...baseConfig.test.coverage,
-        exclude: [
-          ...baseConfig.test.coverage.exclude,
-          // All defaults already included
-        ],
-      },
     },
   };
 });

packages/core/vitest.int.config.ts

@@ -15,13 +15,6 @@ export default defineConfig(() => {
         '../../testing/test-setup/src/lib/console.mock.ts',
         '../../testing/test-setup/src/lib/reset.mocks.ts',
       ],
-      coverage: {
-        ...baseConfig.test.coverage,
-        exclude: [
-          ...baseConfig.test.coverage.exclude,
-          // All defaults already included
-        ],
-      },
     },
   };
 });

packages/core/vitest.unit.config.ts

@@ -11,13 +11,6 @@ export default defineConfig(() => {
     ...baseConfig,
     test: {
       ...baseConfig.test,
-      coverage: {
-        ...baseConfig.test.coverage,
-        exclude: [
-          ...baseConfig.test.coverage.exclude,
-          // Core-specific excludes (already has mocks/** and **/types.ts)
-        ],
-      },
     },
   };
 });

packages/models/eslint.config.js

@@ -19,6 +19,6 @@ export default tseslint.config(
     },
   },
   {
-    ignores: ['packages/models/transformers/**/*'],
+    ignores: ['packages/models/transformers/**/*.ts'],
   },
 );

packages/models/transformers/eslint.config.cjs

@@ -8,14 +8,4 @@ module.exports = [
       '@nx/dependency-checks': 'error',
     },
   },
-  {
-    files: ['**/*.ts', '**/*.js'],
-    rules: {
-      // Allow CommonJS in this transformer package
-      'import/no-commonjs': 'off',
-      '@typescript-eslint/no-require-imports': 'off',
-      'unicorn/prefer-module': 'off',
-      'functional/immutable-data': 'off',
-    },
-  },
 ];

packages/utils/vitest.unit.config.ts

@@ -1,5 +1,8 @@
 import { defineConfig } from 'vitest/config';
-import { createSharedUnitVitestConfig } from '../../testing/test-vitest-setup/src/utils/project-config.js';
+import {
+  TYPE_TEST_CONFIG,
+  createSharedUnitVitestConfig,
+} from '../../testing/test-vitest-setup/src/utils/project-config.js';
 
 export default defineConfig(() => {
   const baseConfig = createSharedUnitVitestConfig({
@@ -11,24 +14,15 @@ export default defineConfig(() => {
     ...baseConfig,
     test: {
       ...baseConfig.test,
-      include: ['src/**/*.{unit,type}.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
+      ...TYPE_TEST_CONFIG,
       setupFiles: [
-        '../../testing/test-setup/src/lib/cliui.mock.ts',
-        '../../testing/test-setup/src/lib/fs.mock.ts',
-        '../../testing/test-setup/src/lib/console.mock.ts',
-        '../../testing/test-setup/src/lib/reset.mocks.ts',
-        '../../testing/test-setup/src/lib/extend/ui-logger.matcher.ts',
-        '../../testing/test-setup/src/lib/extend/markdown-table.matcher.ts',
+        ...baseConfig.test.setupFiles,
         '../../testing/test-setup/src/lib/extend/path.matcher.ts',
-        '../../testing/test-setup/src/lib/extend/jest-extended.matcher.ts',
       ],
       coverage: {
         ...baseConfig.test.coverage,
         exclude: [...baseConfig.test.coverage.exclude, 'perf/**'],
       },
-      typecheck: {
-        include: ['**/*.type.test.ts'],
-      },
     },
   };
 });

testing/test-vitest-setup/README.md

@@ -1,16 +1,21 @@
 import { tsconfigPathAliases } from './tsconfig-path-aliases.js';
 
-// Test timeout constants
 const UNIT_TEST_TIMEOUT = 5000;
 const INTEGRATION_TEST_TIMEOUT = 15_000;
 const E2E_TEST_TIMEOUT = 30_000;
 
+export const TYPE_TEST_CONFIG = {
+  include: [`src/**/*.{unit,type}.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}`],
+  typecheck: {
+    include: ['**/*.type.test.ts'],
+  },
+};
+
 export type SharedVitestConfigOptions = {
   projectRoot: string;
   workspaceRoot: string;
 };
 
-// Define a unified coverage config interface
 type CoverageConfig = {
   enabled?: boolean;
   provider: 'v8';
@@ -69,8 +74,8 @@ function getDefaultTestSettings(
     testTimeout: defaultTimeout,
     setupFiles: [
       noFsCwd
-        ? '../../testing/test-setup/src/lib/fs-memfs.setup-file.ts' // Only fs, no cwd
-        : '../../testing/test-setup/src/lib/fs-with-cwd.setup-file.ts', // fs + cwd
+        ? '../../testing/test-setup/src/lib/fs-memfs.setup-file.ts'
+        : '../../testing/test-setup/src/lib/fs-with-cwd.setup-file.ts',
       '../../testing/test-setup/src/lib/cliui.mock.ts',
       '../../testing/test-setup/src/lib/git.mock.ts',
       '../../testing/test-setup/src/lib/console.mock.ts',