refactor(utils): unify colour range limit values

Author: Tlacenka

packages/utils/src/lib/constants.ts

@@ -0,0 +1,4 @@
+export const SCORE_COLOR_RANGE = {
+  GREEN_MIN: 0.9,
+  YELLOW_MIN: 0.5,
+};

packages/utils/src/lib/report-to-stdout.ts

@@ -1,6 +1,7 @@
 import cliui from '@isaacs/cliui';
 import chalk from 'chalk';
 import Table from 'cli-table3';
+import { SCORE_COLOR_RANGE } from './constants';
 import { NEW_LINE } from './md';
 import {
   CODE_PUSHUP_DOMAIN,
@@ -101,14 +102,16 @@ function reportToDetailSection(report: ScoredReport): string {
 }
 
 function withColor({ score, text }: { score: number; text?: string }) {
-  let str = text ?? formatReportScore(score);
+  const formattedScore = text ?? formatReportScore(score);
   const style = text ? chalk : chalk.bold;
-  if (score < 0.5) {
-    str = style.red(str);
-  } else if (score < 0.9) {
-    str = style.yellow(str);
-  } else {
-    str = style.green(str);
+
+  if (score >= SCORE_COLOR_RANGE.GREEN_MIN) {
+    return style.green(formattedScore);
+  }
+
+  if (score >= SCORE_COLOR_RANGE.YELLOW_MIN) {
+    return style.yellow(formattedScore);
   }
-  return str;
+
+  return style.red(formattedScore);
 }

packages/utils/src/lib/report.ts

@@ -9,6 +9,7 @@ import {
   Report,
   reportSchema,
 } from '@code-pushup/models';
+import { SCORE_COLOR_RANGE } from './constants';
 import {
   ensureDirectoryExists,
   readJsonFile,
@@ -62,20 +63,20 @@ export function formatReportScore(score: number): string {
 }
 
 export function getRoundScoreMarker(score: number): string {
-  if (score >= 0.9) {
+  if (score >= SCORE_COLOR_RANGE.GREEN_MIN) {
     return '🟢';
   }
-  if (score >= 0.5) {
+  if (score >= SCORE_COLOR_RANGE.YELLOW_MIN) {
     return '🟡';
   }
   return '🔴';
 }
 
 export function getSquaredScoreMarker(score: number): string {
-  if (score >= 0.9) {
+  if (score >= SCORE_COLOR_RANGE.GREEN_MIN) {
     return '🟩';
   }
-  if (score >= 0.5) {
+  if (score >= SCORE_COLOR_RANGE.YELLOW_MIN) {
     return '🟨';
   }
   return '🟥';