refactor(models): import material icons from different package

Author: matejchalk

package-lock.json

@@ -56,6 +56,7 @@
     "multi-progress-bars": "^5.0.3",
     "parse-lcov": "^1.0.4",
     "simple-git": "^3.20.0",
+    "vscode-material-icons": "^0.1.0",
     "yargs": "^17.7.2",
     "zod": "^3.22.4"
   },

package.json

@@ -4,6 +4,6 @@
   "license": "MIT",
   "dependencies": {
     "zod": "^3.22.1",
-    "@code-pushup/portal-client": "^0.5.0"
+    "vscode-material-icons": "^0.1.0"
   }
 }

packages/models/package.json

@@ -34,6 +34,7 @@ export {
   MAX_TITLE_LENGTH,
 } from './lib/implementation/limits';
 export {
+  MaterialIcon,
   fileNameSchema,
   filePathSchema,
   materialIconSchema,

packages/models/src/index.ts

@@ -1,5 +1,5 @@
+import { MATERIAL_ICONS } from 'vscode-material-icons';
 import { ZodObject, ZodOptional, ZodString, z } from 'zod';
-import { MATERIAL_ICONS, MaterialIcon } from '@code-pushup/portal-client';
 import {
   MAX_DESCRIPTION_LENGTH,
   MAX_SLUG_LENGTH,
@@ -207,10 +207,10 @@ export function scorableSchema<T extends ReturnType<typeof weightedRefSchema>>(
   );
 }
 
-export const materialIconSchema = z.enum(
-  MATERIAL_ICONS as [MaterialIcon, MaterialIcon, ...MaterialIcon[]],
-  { description: 'Icon from VSCode Material Icons extension' },
-);
+export const materialIconSchema = z.enum(MATERIAL_ICONS, {
+  description: 'Icon from VSCode Material Icons extension',
+});
+export type MaterialIcon = z.infer<typeof materialIconSchema>;
 
 type Ref = { weight: number };