chore(utils): fix typings, minor refactor

Author: MishaSeredenkoPushBased

packages/core/src/lib/implementation/execute-plugin.ts

@@ -147,22 +147,15 @@ export async function executePlugins(
 
   logMultipleResults(results, 'Plugins', undefined, errorsCallback);
 
-  const { fulfilled, rejected } = groupByStatus(results) as {
-    fulfilled: PromiseFulfilledResult<PluginReport>[];
-    rejected: PromiseRejectedResult[];
-  };
+  const { fulfilled, rejected } = groupByStatus(results);
   if (rejected.length) {
-    const errorMessages = rejected
-      .map(({ reason }: PromiseRejectedResult) => reason)
-      .join(', ');
+    const errorMessages = rejected.map(({ reason }) => reason).join(', ');
     throw new Error(
       `Plugins failed: ${rejected.length} errors: ${errorMessages}`,
     );
   }
 
-  return fulfilled.map(
-    (result: PromiseFulfilledResult<PluginReport>) => result.value,
-  );
+  return fulfilled.map(result => result.value);
 }
 
 function auditOutputsCorrelateWithPluginOutput(

packages/utils/src/lib/group-by-status.ts

@@ -6,16 +6,14 @@ export function groupByStatus<T>(results: PromiseSettledResult<T>[]): {
     fulfilled: PromiseFulfilledResult<T>[];
     rejected: PromiseRejectedResult[];
   }>(
-    (accumulator, currentValue) => {
-      if (currentValue.status === 'fulfilled' && 'value' in currentValue) {
-        accumulator.fulfilled.push(currentValue);
-      } else if (
-        currentValue.status === 'rejected' &&
-        'reason' in currentValue
-      ) {
-        accumulator.rejected.push(currentValue);
+    (acc, result) => {
+      if (result.status === 'fulfilled') {
+        return { ...acc, fulfilled: [...acc.fulfilled, result] };
       }
-      return accumulator;
+      if (result.status === 'rejected') {
+        return { ...acc, rejected: [...acc.rejected, result] };
+      }
+      return acc;
     },
     { fulfilled: [], rejected: [] },
   );