refactor(cli): reuse coerceBooleanValue utility

Author: matejchalk

packages/cli/src/lib/implementation/set-verbose.middleware.int.test.ts

@@ -14,7 +14,7 @@ describe('setVerboseMiddleware', () => {
     [false, false, false],
     ['True', undefined, true],
     ['TRUE', undefined, true],
-    [42, undefined, false],
+    [0, undefined, false],
     [undefined, 'true', true],
     [true, 'False', false],
   ])(

packages/cli/src/lib/implementation/set-verbose.middleware.ts

@@ -1,5 +1,6 @@
 import type { GlobalOptions } from '@code-pushup/core';
 import type { CoreConfig } from '@code-pushup/models';
+import { coerceBooleanValue } from '@code-pushup/utils';
 import type { FilterOptions } from './filter.model.js';
 import type { GeneralCliOptions } from './global.model';
 
@@ -21,8 +22,8 @@ import type { GeneralCliOptions } from './global.model';
 export function setVerboseMiddleware<
   T extends GeneralCliOptions & CoreConfig & FilterOptions & GlobalOptions,
 >(originalProcessArgs: T): T {
-  const envVerbose = getNormalizedOptionValue(process.env['CP_VERBOSE']);
-  const cliVerbose = getNormalizedOptionValue(originalProcessArgs.verbose);
+  const envVerbose = coerceBooleanValue(process.env['CP_VERBOSE']);
+  const cliVerbose = coerceBooleanValue(originalProcessArgs.verbose);
   const verboseEffect = cliVerbose ?? envVerbose ?? false;
 
   // eslint-disable-next-line functional/immutable-data
@@ -33,20 +34,3 @@ export function setVerboseMiddleware<
     verbose: verboseEffect,
   };
 }
-
-export function getNormalizedOptionValue(value: unknown): boolean | undefined {
-  if (typeof value === 'boolean') {
-    return value;
-  }
-  if (typeof value === 'string') {
-    const lowerCaseValue = value.toLowerCase();
-    if (lowerCaseValue === 'true') {
-      return true;
-    }
-    if (lowerCaseValue === 'false') {
-      return false;
-    }
-  }
-
-  return undefined;
-}

packages/cli/src/lib/implementation/set-verbose.middleware.unit.test.ts

@@ -1,32 +1,7 @@
 import { describe, expect, it, vi } from 'vitest';
-import {
-  getNormalizedOptionValue,
-  setVerboseMiddleware,
-} from './set-verbose.middleware.js';
+import { setVerboseMiddleware } from './set-verbose.middleware.js';
 
 describe('setVerboseMiddleware', () => {
-  it.each([
-    [true, true],
-    ['true', true],
-    ['True', true],
-    ['TRUE', true],
-    [false, false],
-    ['false', false],
-    ['False', false],
-    ['FALSE', false],
-    [undefined, undefined],
-    ['undefined', undefined],
-    ['Whatever else', undefined],
-    [0, undefined],
-    [1, undefined],
-    [null, undefined],
-  ])(
-    'should return normalize value of `%j` option set as `%j`',
-    (value, expected) => {
-      expect(getNormalizedOptionValue(value)).toBe(expected);
-    },
-  );
-
   it.each([
     [true, undefined, true],
     [false, undefined, false],