Merge branch 'master' into feat/auth-session-fix

Author: NitayRabi

.github/workflows/knip.yml

@@ -0,0 +1,27 @@
+name: Knip
+
+on:
+  push:
+    branches: [main, master, develop]
+  pull_request:
+    branches: [main, master, develop]
+
+jobs:
+  knip:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20.x'
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run knip
+        run: npx -y knip@5

.github/workflows/release.yml

@@ -7,6 +7,11 @@ on:
 jobs:
   release:
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      issues: write
+      pull-requests: write
+      id-token: write
     steps:
       - uses: actions/checkout@v4
         with:
@@ -16,16 +21,11 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: '18'
+          node-version: '20'
           registry-url: 'https://registry.npmjs.org'
 
-      - name: Configure NPM authentication
-        run: |
-          echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
-          npm whoami
-        env:
-          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+      - name: Upgrade npm for trusted publishing
+        run: npm install -g npm@latest
 
       - name: Install dependencies
         run: npm ci
@@ -37,10 +37,13 @@ jobs:
         run: npm test --if-present
 
       - name: Semantic Release
+        id: semantic
         uses: cycjimmy/semantic-release-action@v4
         with:
-          semantic_version: 22
+          semantic_version: 24
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+
+      - name: Publish to npm (trusted publishing via OIDC)
+        if: steps.semantic.outputs.new_release_published == 'true'
+        run: npm publish --provenance --access public

.gitignore

@@ -148,4 +148,5 @@ ib-gateway/clientportal.gw/.vertx
 ib-gateway/clientportal.gw/.vertx/
 
 # Docker volumes
-data/
+data/
+.claude/settings.local.json

.releaserc

@@ -21,7 +21,7 @@
         ]
       }
     ],
-    "@semantic-release/npm",
+    ["@semantic-release/npm", { "npmPublish": false }],
     "@semantic-release/github"
   ]
 }

README.md

@@ -222,4 +222,12 @@ For a complete guide on creating and customizing Flex Queries, see the [IB Flex
 
 ## License
 
-MIT License - see LICENSE file for details.
+MIT License - see LICENSE file for details.
+
+## Thanks to our contributors
+
+A big thank you to everyone who has contributed to making this project better.
+
+<a href="https://github.com/code-rabi/interactive-brokers-mcp/graphs/contributors">
+  <img src="https://contrib.rocks/image?repo=code-rabi/interactive-brokers-mcp" alt="Contributors" />
+</a>

knip.json

@@ -0,0 +1,12 @@
+{
+  "$schema": "https://unpkg.com/knip@5/schema.json",
+  "ignore": ["ib-gateway/**"],
+  "ignoreDependencies": [
+    "@semantic-release/commit-analyzer",
+    "@semantic-release/github",
+    "@semantic-release/npm",
+    "@semantic-release/release-notes-generator",
+    "conventional-changelog-conventionalcommits",
+    "semantic-release"
+  ]
+}

package-lock.json

@@ -39,6 +39,14 @@
   ],
   "author": "Nitay Rabinovich",
   "license": "MIT",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/code-rabi/interactive-brokers-mcp.git"
+  },
+  "bugs": {
+    "url": "https://github.com/code-rabi/interactive-brokers-mcp/issues"
+  },
+  "homepage": "https://github.com/code-rabi/interactive-brokers-mcp#readme",
   "dependencies": {
     "@modelcontextprotocol/sdk": "^1.17.2",
     "axios": "^1.6.0",

package.json

@@ -2,18 +2,18 @@ import axios, { AxiosInstance } from "axios";
 import { Logger } from "./logger.js";
 import { parseStringPromise } from "xml2js";
 
-export interface FlexQueryClientConfig {
+interface FlexQueryClientConfig {
   token: string;
 }
 
-export interface FlexQueryResponse {
+interface FlexQueryResponse {
   referenceCode?: string;
   url?: string;
   error?: string;
   errorCode?: string;
 }
 
-export interface FlexStatementResponse {
+interface FlexStatementResponse {
   data?: string; // XML data
   error?: string;
   errorCode?: string;
@@ -24,6 +24,21 @@ export interface FlexStatementResponse {
  * API Documentation: https://www.interactivebrokers.com/en/software/am/am/reports/flex_web_service_version_3.htm
  */
 export class FlexQueryClient {
+  // IB Flex Web Service error codes that mean "try again shortly" — the statement
+  // is being prepared. All other Fail codes are terminal (bad token, invalid query, etc.).
+  private static readonly TRANSIENT_GET_STATEMENT_ERROR_CODES = new Set([
+    "1001", // Statement could not be generated at this time
+    "1004", // Statement is incomplete at this time
+    "1005", // Settlement data is not ready
+    "1006", // FIFO P/L data is not ready
+    "1007", // MTM P/L data is not ready
+    "1008", // MTM and FIFO P/L data is not ready
+    "1009", // Server is under heavy load
+    "1018", // Too many requests from this token
+    "1019", // Statement generation in progress
+    "1021", // Statement could not be retrieved at this time
+  ]);
+
   private client: AxiosInstance;
   private token: string;
   // Fixed: gdcdyn → ndcdyn, /Universal/servlet → /AccountManagement/FlexWebService
@@ -182,16 +197,21 @@ export class FlexQueryClient {
       const statementResponse = await this.getStatement(sendResponse.referenceCode);
 
       if (statementResponse.error) {
-        // Check if it's a "not ready yet" error
-        if (
-          statementResponse.errorCode === "1019" || // Statement generation in progress
-          statementResponse.error.includes("in progress") ||
-          statementResponse.error.includes("not ready")
-        ) {
-          Logger.log(`[FLEX-QUERY] Statement not ready yet, retrying...`);
+        const code = statementResponse.errorCode ?? "";
+        const normalizedError = statementResponse.error.toLowerCase();
+        const isTransient =
+          FlexQueryClient.TRANSIENT_GET_STATEMENT_ERROR_CODES.has(code) ||
+          normalizedError.includes("in progress") ||
+          normalizedError.includes("not ready") ||
+          normalizedError.includes("try again");
+
+        if (isTransient) {
+          Logger.log(
+            `[FLEX-QUERY] Statement not ready yet (code ${code || "?"}: ${statementResponse.error}), retrying...`
+          );
           continue;
         }
-        
+
         // It's a real error
         return statementResponse;
       }
@@ -226,4 +246,3 @@ export class FlexQueryClient {
 }
 
 
-

src/flex-query-client.ts

@@ -12,7 +12,7 @@ export interface SavedFlexQuery {
   lastUsed?: string;
 }
 
-export interface FlexQueriesStore {
+interface FlexQueriesStore {
   queries: SavedFlexQuery[];
 }