Allow "max" option for "reasoningEffort" field in config schema#3744
Merged
code-yeongyu merged 2 commits intocode-yeongyu:devfrom May 6, 2026
Merged
Allow "max" option for "reasoningEffort" field in config schema#3744code-yeongyu merged 2 commits intocode-yeongyu:devfrom
code-yeongyu merged 2 commits intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c6fd2e5a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- There is a concrete compatibility risk:
assets/oh-my-opencode.schema.jsonnow allowsreasoningEffort: "max", but runtime mapping still tops out atxhigh, so valid-by-schema configs may fail or be ignored during resolution. - Given the 5/10 severity with high confidence (9/10), this is a moderate regression risk that can affect users supplying the new value, so this is not fully low-risk yet.
- Pay close attention to
assets/oh-my-opencode.schema.json- keep schema and runtime reasoning-effort mapping aligned somaxis handled consistently.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="assets/oh-my-opencode.schema.json">
<violation number="1" location="assets/oh-my-opencode.schema.json:132">
P2: Schema accepts `reasoningEffort: "max"` but runtime compatibility/mapping still only supports up to `xhigh`, so configs using `max` will be dropped or rejected during resolution.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listing "max" as a valid value for "reasoningEffort" as many providers are accepting this value (e.g., DeepSeek-V4 and Claude Opus).
Need help on this PR? Tag
@codesmithwith what you need.