Skip to content

Allow "max" option for "reasoningEffort" field in config schema#3744

Merged
code-yeongyu merged 2 commits intocode-yeongyu:devfrom
Arcadi4:dev
May 6, 2026
Merged

Allow "max" option for "reasoningEffort" field in config schema#3744
code-yeongyu merged 2 commits intocode-yeongyu:devfrom
Arcadi4:dev

Conversation

@Arcadi4
Copy link
Copy Markdown
Contributor

@Arcadi4 Arcadi4 commented May 1, 2026

Listing "max" as a valid value for "reasoningEffort" as many providers are accepting this value (e.g., DeepSeek-V4 and Claude Opus).


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

All contributors have signed the CLA. Thank you! ✅
Posted by the CLA Assistant Lite bot.

@Arcadi4
Copy link
Copy Markdown
Contributor Author

Arcadi4 commented May 1, 2026

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 1, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c6fd2e5a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assets/oh-my-opencode.schema.json
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 3/5

  • There is a concrete compatibility risk: assets/oh-my-opencode.schema.json now allows reasoningEffort: "max", but runtime mapping still tops out at xhigh, so valid-by-schema configs may fail or be ignored during resolution.
  • Given the 5/10 severity with high confidence (9/10), this is a moderate regression risk that can affect users supplying the new value, so this is not fully low-risk yet.
  • Pay close attention to assets/oh-my-opencode.schema.json - keep schema and runtime reasoning-effort mapping aligned so max is handled consistently.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="assets/oh-my-opencode.schema.json">

<violation number="1" location="assets/oh-my-opencode.schema.json:132">
P2: Schema accepts `reasoningEffort: "max"` but runtime compatibility/mapping still only supports up to `xhigh`, so configs using `max` will be dropped or rejected during resolution.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread assets/oh-my-opencode.schema.json
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Auto-approved: Additive change to reasoningEffort enum and compatibility ladder; no existing logic is modified in a way that could cause regressions.

@code-yeongyu code-yeongyu merged commit 9b87fd5 into code-yeongyu:dev May 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants