Skip to content

fix: resolve simple triaged GitHub bugs#3748

Merged
code-yeongyu merged 3 commits intodevfrom
fix/simple-github-bugs-1948-3564
May 6, 2026
Merged

fix: resolve simple triaged GitHub bugs#3748
code-yeongyu merged 3 commits intodevfrom
fix/simple-github-bugs-1948-3564

Conversation

@code-yeongyu
Copy link
Copy Markdown
Owner

@code-yeongyu code-yeongyu commented May 1, 2026

Summary

  • Return a clear subagent_type is required error for malformed call_omo_agent calls instead of throwing.
  • Normalize bare JSON Schema $ref values to #/$defs/... pointers.
  • Treat gh as installed when Bun.which misses it but gh --version succeeds.

Verification

  • bun test src/tools/call-omo-agent/tools.test.ts src/plugin/normalize-tool-arg-schemas.test.ts src/cli/doctor/checks/tools-gh.test.ts
  • bun run typecheck
  • bun run build
  • bun run script/run-ci-tests.ts
  • Manual Bun driver scripts for all three changed surfaces

Notes

  • Plain bun test still fails when run all-at-once because several existing tests require isolated execution; the project CI split runner passes.

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

code-yeongyu and others added 3 commits May 1, 2026 18:55
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Confidence score: 3/5

  • There is a concrete regression risk in src/plugin/normalize-tool-arg-schemas.ts: $ref normalization may rewrite valid relative URI refs (with path/fragment) into #/$defs/..., which can break schema link resolution at runtime.
  • The reported severity/confidence (6/10, 8/10) suggests this is more than a cosmetic issue, so the merge carries some user-facing risk unless this behavior is constrained or fixed.
  • Pay close attention to src/plugin/normalize-tool-arg-schemas.ts - ensure relative $ref values with paths/fragments are preserved correctly during normalization.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/plugin/normalize-tool-arg-schemas.ts">

<violation number="1" location="src/plugin/normalize-tool-arg-schemas.ts:51">
P2: `$ref` normalization rewrites valid relative URI references (with path/fragment) into `#/$defs/...`, which can corrupt schema links.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

}

function normalizeJsonSchemaRef(value: string): string {
if (value.startsWith("#") || value.includes(":") || value.startsWith("/")) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: $ref normalization rewrites valid relative URI references (with path/fragment) into #/$defs/..., which can corrupt schema links.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/plugin/normalize-tool-arg-schemas.ts, line 51:

<comment>`$ref` normalization rewrites valid relative URI references (with path/fragment) into `#/$defs/...`, which can corrupt schema links.</comment>

<file context>
@@ -47,6 +47,14 @@ function isRecord(value: unknown): value is Record<string, unknown> {
 }
 
+function normalizeJsonSchemaRef(value: string): string {
+  if (value.startsWith("#") || value.includes(":") || value.startsWith("/")) {
+    return value
+  }
</file context>

@code-yeongyu code-yeongyu merged commit 1ad0fd4 into dev May 6, 2026
8 checks passed
@code-yeongyu code-yeongyu deleted the fix/simple-github-bugs-1948-3564 branch May 6, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant