fix: resolve simple triaged GitHub bugs#3748
Merged
code-yeongyu merged 3 commits intodevfrom May 6, 2026
Merged
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
There was a problem hiding this comment.
1 issue found across 6 files
Confidence score: 3/5
- There is a concrete regression risk in
src/plugin/normalize-tool-arg-schemas.ts:$refnormalization may rewrite valid relative URI refs (with path/fragment) into#/$defs/..., which can break schema link resolution at runtime. - The reported severity/confidence (6/10, 8/10) suggests this is more than a cosmetic issue, so the merge carries some user-facing risk unless this behavior is constrained or fixed.
- Pay close attention to
src/plugin/normalize-tool-arg-schemas.ts- ensure relative$refvalues with paths/fragments are preserved correctly during normalization.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/plugin/normalize-tool-arg-schemas.ts">
<violation number="1" location="src/plugin/normalize-tool-arg-schemas.ts:51">
P2: `$ref` normalization rewrites valid relative URI references (with path/fragment) into `#/$defs/...`, which can corrupt schema links.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| } | ||
|
|
||
| function normalizeJsonSchemaRef(value: string): string { | ||
| if (value.startsWith("#") || value.includes(":") || value.startsWith("/")) { |
There was a problem hiding this comment.
P2: $ref normalization rewrites valid relative URI references (with path/fragment) into #/$defs/..., which can corrupt schema links.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/plugin/normalize-tool-arg-schemas.ts, line 51:
<comment>`$ref` normalization rewrites valid relative URI references (with path/fragment) into `#/$defs/...`, which can corrupt schema links.</comment>
<file context>
@@ -47,6 +47,14 @@ function isRecord(value: unknown): value is Record<string, unknown> {
}
+function normalizeJsonSchemaRef(value: string): string {
+ if (value.startsWith("#") || value.includes(":") || value.startsWith("/")) {
+ return value
+ }
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subagent_type is requirederror for malformedcall_omo_agentcalls instead of throwing.$refvalues to#/$defs/...pointers.ghas installed whenBun.whichmisses it butgh --versionsucceeds.Verification
bun test src/tools/call-omo-agent/tools.test.ts src/plugin/normalize-tool-arg-schemas.test.ts src/cli/doctor/checks/tools-gh.test.tsbun run typecheckbun run buildbun run script/run-ci-tests.tsNotes
bun teststill fails when run all-at-once because several existing tests require isolated execution; the project CI split runner passes.Need help on this PR? Tag
@codesmithwith what you need.