fix: Code Quality improvements to response record endpoint and added unit tests (calcom#22264)

* chore: remove unnecessary logs and fix documentation

* refactor: extract GetSlotsInputWithRouting type and eliminate code duplication

- Move GetSlotsInputWithRouting_2024_09_04 type to platform-types package for reuse
- Refactor slots service to eliminate duplicate error handling logic
- Fix TypeScript errors in slots service tests by adding missing type property
- Update test expectations to match new implementation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* refactor: improve type safety in slots service

- Export explicit types from slots-input.service for transformed queries
- Replace 'any' type with proper TransformedSlotsQuery union type
- Re-implement fetchAndFormatSlots abstraction to eliminate code duplication
- Revert unrelated console.log in router.controller.ts

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* refactor: simplify slots service implementation

- Remove intermediate variable assignment in getAvailableSlotsWithRouting
- Update test to match simplified routing parameters structure

* test: add comprehensive error handling and edge case tests for slots service

- Add error scenario tests for NotFoundException, invalid time range, and generic errors
- Add edge case tests for null/undefined parameters and empty arrays
- Improve test coverage for getAvailableSlotsWithRouting method
- Mock SlotsInputService properly to enable isolated unit testing

* 📝 CodeRabbit Chat: Rename TransformedGetSlotsQuery types to InternalGetSlotsQuery in slot services

* fix: correct import path for AvailableSlotsService in slots service test

- Fix import path from '@/lib/services/AvailableSlots' to '@/lib/services/available-slots.service'
- Resolves unit test failure due to case sensitivity/naming mismatch
- All API v2 tests now pass (9 test suites, 142 tests)

Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Author: 4 people

apps/api/v2/src/modules/organizations/routing-forms/outputs/create-routing-form-response.output.ts

@@ -86,11 +86,10 @@ export class CreateRoutingFormResponseOutputData {
   eventTypeId?: number;
 
   @ValidateNested()
-  @ApiProperty({ type: Routing })
   @Type(() => Routing)
   @ApiPropertyOptional({
     type: Routing,
-    description: "The routing information.",
+    description: "The routing information that could be passed as is to the booking API.",
     example: {
       eventTypeId: 123,
       routing: {
@@ -100,8 +99,6 @@ export class CreateRoutingFormResponseOutputData {
       },
     },
   })
-  @ValidateNested()
-  @Type(() => Routing)
   routing?: Routing;
 
   @IsString()

apps/api/v2/src/modules/organizations/routing-forms/services/shared-routing-form-response.service.ts

@@ -55,15 +55,14 @@ export class SharedRoutingFormResponseService {
     // Extract event type information from the routed URL
     const { eventTypeId, crmParams } = await this.extractEventTypeAndCrmParams(user.id, redirectUrl);
 
-    const paramsForGetAvailableSlots = {
+    // Get available slots using the slots service with CRM parameters
+    const slots = await this.slotsService.getAvailableSlotsWithRouting({
       type: ById_2024_09_04_type,
       eventTypeId,
       ...slotsQuery,
       ...crmParams,
-    } as const;
+    });
 
-    // Get available slots using the slots service with CRM parameters
-    const slots = await this.slotsService.getAvailableSlots(paramsForGetAvailableSlots);
     const teamMemberIds = crmParams.routedTeamMemberIds ?? [];
     const teamMemberEmail = crmParams.teamMemberEmail ?? undefined;
     const skipContactOwner = crmParams.skipContactOwner ?? undefined;

apps/api/v2/src/modules/slots/slots-2024-09-04/services/slots-input.service.ts

@@ -13,11 +13,32 @@ import {
   ByUsernameAndEventTypeSlug_2024_09_04,
   ByTeamSlugAndEventTypeSlug_2024_09_04,
   GetSlotsInput_2024_09_04,
+  GetSlotsInputWithRouting_2024_09_04,
   ById_2024_09_04_type,
   ByUsernameAndEventTypeSlug_2024_09_04_type,
   ByTeamSlugAndEventTypeSlug_2024_09_04_type,
 } from "@calcom/platform-types";
 
+export type InternalGetSlotsQuery = {
+  isTeamEvent: boolean;
+  startTime: string;
+  endTime: string;
+  duration?: number;
+  eventTypeId: number;
+  eventTypeSlug: string;
+  usernameList: string[];
+  timeZone: string | undefined;
+  orgSlug: string | null | undefined;
+  rescheduleUid: string | null;
+};
+
+export type InternalGetSlotsQueryWithRouting = InternalGetSlotsQuery & {
+  routedTeamMemberIds: number[] | null;
+  skipContactOwner: boolean;
+  teamMemberEmail: string | null;
+  routingFormResponseId: number | undefined;
+};
+
 @Injectable()
 export class SlotsInputService_2024_09_04 {
   constructor(
@@ -30,7 +51,7 @@ export class SlotsInputService_2024_09_04 {
     private readonly teamsEventTypesRepository: TeamsEventTypesRepository
   ) {}
 
-  async transformGetSlotsQuery(query: GetSlotsInput_2024_09_04) {
+  async transformGetSlotsQuery(query: GetSlotsInput_2024_09_04): Promise<InternalGetSlotsQuery> {
     const eventType = await this.getEventType(query);
     if (!eventType) {
       throw new NotFoundException(`Event Type not found`);
@@ -46,10 +67,6 @@ export class SlotsInputService_2024_09_04 {
     const timeZone = query.timeZone;
     const orgSlug = "organizationSlug" in query ? query.organizationSlug : null;
     const rescheduleUid = query.bookingUidToReschedule || null;
-    const routedTeamMemberIds = query.routedTeamMemberIds || null;
-    const skipContactOwner = query.skipContactOwner || false;
-    const teamMemberEmail = query.teamMemberEmail || null;
-    const routingFormResponseId = query.routingFormResponseId || null;
 
     return {
       isTeamEvent,
@@ -62,10 +79,23 @@ export class SlotsInputService_2024_09_04 {
       timeZone,
       orgSlug,
       rescheduleUid,
-      routedTeamMemberIds,
-      skipContactOwner,
-      teamMemberEmail,
-      routingFormResponseId,
+    };
+  }
+
+  async transformRoutingGetSlotsQuery(
+    query: GetSlotsInputWithRouting_2024_09_04
+  ): Promise<InternalGetSlotsQueryWithRouting> {
+    const { routedTeamMemberIds, skipContactOwner, teamMemberEmail, routingFormResponseId, ...baseQuery } =
+      query;
+
+    const baseTransformation = await this.transformGetSlotsQuery(baseQuery);
+
+    return {
+      ...baseTransformation,
+      routedTeamMemberIds: routedTeamMemberIds || null,
+      skipContactOwner: skipContactOwner || false,
+      teamMemberEmail: teamMemberEmail || null,
+      routingFormResponseId: routingFormResponseId ?? undefined,
     };
   }