Skip to content

Commit a4a01a0

Browse files
authored
cleanup(attributes): remove entrypoints (calcom#29034)
* refactor: remove attributes and segments entrypoints * fix: restore segment entrypoints * cleanup
1 parent 46eb533 commit a4a01a0

4 files changed

Lines changed: 5 additions & 20 deletions

File tree

apps/web/app/(use-page-wrapper)/settings/(settings-layout)/SettingsLayoutAppDirClient.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,6 @@ interface SettingsPermissions {
265265
canViewRoles?: boolean;
266266
canViewOrganizationBilling?: boolean;
267267
canUpdateOrganization?: boolean;
268-
canViewAttributes?: boolean;
269268
}
270269

271270
const useTabs = ({
@@ -296,14 +295,6 @@ const useTabs = ({
296295
(child) => permissions?.canUpdateOrganization || !organizationAdminKeys.includes(child.name)
297296
);
298297

299-
if (permissions?.canViewAttributes) {
300-
newArray.splice(4, 0, {
301-
name: "attributes",
302-
href: "/settings/organizations/attributes",
303-
trackingMetadata: { section: "organization", page: "attributes" },
304-
});
305-
}
306-
307298
// Add delegation-credential menu item only if feature flag is enabled
308299
if (isDelegationCredentialEnabled) {
309300
newArray.push({

apps/web/app/(use-page-wrapper)/settings/(settings-layout)/layout.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export default async function SettingsLayoutAppDir(props: SettingsLayoutProps) {
2020
canViewRoles: false,
2121
canViewOrganizationBilling: false,
2222
canUpdateOrganization: false,
23-
canViewAttributes: false,
2423
}}
2524
/>
2625
);

apps/web/modules/bookings/components/BookingListContainer.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
"use client";
22

33
import dayjs from "@calcom/dayjs";
4-
import { useDataTable } from "~/data-table/hooks/useDataTable";
5-
import { useDisplayedFilterCount } from "~/data-table/hooks/useDisplayedFilterCount";
64
import { useLocale } from "@calcom/lib/hooks/useLocale";
75
import { trpc } from "@calcom/trpc/react";
86
import useMeQuery from "@calcom/trpc/react/hooks/useMeQuery";
@@ -21,6 +19,8 @@ import { useBookingStatusTab } from "~/bookings/hooks/useBookingStatusTab";
2119
import { useFacetedUniqueValues } from "~/bookings/hooks/useFacetedUniqueValues";
2220
import { useListAutoSelector } from "~/bookings/hooks/useListAutoSelector";
2321
import { DataTableFilters, DataTableSegment } from "~/data-table/components";
22+
import { useDataTable } from "~/data-table/hooks/useDataTable";
23+
import { useDisplayedFilterCount } from "~/data-table/hooks/useDisplayedFilterCount";
2424
import {
2525
BookingDetailsSheetStoreProvider,
2626
useBookingDetailsSheetStore,

apps/web/modules/bookings/views/bookings-view.tsx

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
"use client";
22

33
import { ColumnFilterType, type SystemFilterSegment } from "@calcom/features/data-table";
4-
import { DataTableProvider } from "~/data-table/DataTableProvider";
5-
import { useSegments } from "~/data-table/hooks/useSegments";
64
import { useLocale } from "@calcom/lib/hooks/useLocale";
75
import classNames from "@calcom/ui/classNames";
86
import dynamic from "next/dynamic";
97
import { usePathname, useRouter } from "next/navigation";
108
import { useCallback, useMemo } from "react";
9+
import { DataTableProvider } from "~/data-table/DataTableProvider";
10+
import { useSegments } from "~/data-table/hooks/useSegments";
1111
import { BookingListContainer } from "../components/BookingListContainer";
1212
import { useActiveFiltersValidator } from "../hooks/useActiveFiltersValidator";
1313
import { useBookingsView } from "../hooks/useBookingsView";
@@ -77,11 +77,6 @@ export default function Bookings(props: BookingsProps) {
7777

7878
function BookingsContent({ status, permissions, bookingsV3Enabled, bookingAuditEnabled }: BookingsProps) {
7979
const [view] = useBookingsView({ bookingsV3Enabled });
80-
const router = useRouter();
81-
const handleOptInSuccess = useCallback(() => {
82-
router.refresh();
83-
}, [router]);
84-
const optInBanner = null;
8580

8681
return (
8782
<div className={classNames(view === "calendar" && "-mb-8")}>
@@ -100,6 +95,6 @@ function BookingsContent({ status, permissions, bookingsV3Enabled, bookingAuditE
10095
bookingsV3Enabled={bookingsV3Enabled}
10196
/>
10297
)}
103-
</div>
98+
</div>
10499
);
105100
}

0 commit comments

Comments
 (0)