Conversation
* fix: join multiple Reply-To addresses as comma-separated string Some SMTP providers (e.g., SendLayer) reject emails when Reply-To is passed as an array to nodemailer, which serializes it as multiple Reply-To headers. Using a comma-joined string is RFC 2822 compliant and works universally across all SMTP providers. Fixes #28610 * test: add unit tests for getReplyToHeader SMTP compatibility - Verify replyTo is always returned as comma-separated string, not array - Test single email, multiple emails, and empty email cases - Add RFC 5322 compliance test for SMTP compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: add RFC 5322 reference comment to getReplyToHeader tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Lawrence Christian <67164412+LCNDevs@users.noreply.github.com> Co-authored-by: Romit <85230081+romitg2@users.noreply.github.com> Co-authored-by: Romit <romitgabani1.work@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* fix: block localhost and loopback addresses in SSRF protection Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: block loopback IPs by hostname in SSRF protection Add 127.0.0.1, ::1, [::1], and 0.0.0.0 to blocked hostnames list for defense-in-depth protection against SSRF attacks targeting localhost. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Romit <romitgabani1.work@gmail.com> Co-authored-by: Romit <85230081+romitg2@users.noreply.github.com>
…worker shutdown flake (#28630) * fix: mock @calcom/lib/i18n in EventManager.test.ts to prevent vitest worker shutdown flake TranslationService transitively imports @calcom/lib/i18n which triggers slow module resolution via vite's RPC. When the vitest worker shuts down before it completes, it causes 'Closing rpc while fetch was pending' errors. Mocking the module prevents the actual module resolution during test loading. Co-Authored-By: romitgabani1 <romitgabani1.work@gmail.com> * chore: remove explanatory comments per review feedback Co-Authored-By: romitgabani1 <romitgabani1.work@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…sibility (#28631) Both booking-sheet-keyboard.e2e.ts and bookings-list.e2e.ts intermittently timeout in CI when clicking the booking item button before the DOM has finished rendering. Adding explicit waitFor({ state: 'visible' }) on the role=button element after the parent booking item is visible ensures the click target is fully ready. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )