feat: Generate unique names for pool with dataSource & preAggregation… (cube-js#10680)

Author: ovr

packages/cubejs-hive-driver/src/HiveDriver.js

@@ -11,7 +11,7 @@ const {
 } = require('@cubejs-backend/shared');
 const jshs2 = require('jshs2');
 const SqlString = require('sqlstring');
-const { BaseDriver } = require('@cubejs-backend/base-driver');
+const { BaseDriver, createPoolName } = require('@cubejs-backend/base-driver');
 const Connection = require('jshs2/lib/Connection');
 const IDLFactory = require('jshs2/lib/common/IDLFactory');
 
@@ -82,8 +82,9 @@ class HiveDriver extends BaseDriver {
     };
 
     const configuration = new Configuration(this.config);
-    
-    this.pool = new Pool('hive', {
+
+    const poolName = createPoolName('hive', dataSource, preAggregations);
+    this.pool = new Pool(poolName, {
       create: async () => {
         const idl = new IDLContainer();
         await idl.initialize(configuration);

packages/cubejs-jdbc-driver/src/JDBCDriver.ts

@@ -12,6 +12,7 @@ import {
 } from '@cubejs-backend/shared';
 import {
   BaseDriver,
+  createPoolName,
   DownloadQueryResultsOptions,
   DownloadQueryResultsResult,
   StreamOptions,
@@ -138,7 +139,8 @@ export class JDBCDriver extends BaseDriver {
       throw new Error('url is required property');
     }
 
-    this.pool = new Pool('jdbc', {
+    const poolName = createPoolName('jdbc', dataSource, preAggregations);
+    this.pool = new Pool(poolName, {
       create: async () => {
         await initMvn(await this.getCustomClassPath());
 

packages/cubejs-mongobi-driver/src/MongoBIDriver.ts

@@ -13,6 +13,7 @@ import { createConnection, Connection, ConnectionOptions, RowDataPacket, Field }
 import { Readable } from 'stream';
 import {
   BaseDriver,
+  createPoolName,
   DownloadQueryResultsOptions,
   DownloadQueryResultsResult,
   DriverInterface,
@@ -100,7 +101,9 @@ export class MongoBIDriver extends BaseDriver implements DriverInterface {
       flags: ['-CONNECT_ATTRS'],
       ...mongoBIDriverConfiguration
     };
-    this.pool = new Pool('mongobi', {
+
+    const poolName = createPoolName('mongobi', dataSource, preAggregations);
+    this.pool = new Pool(poolName, {
       create: async () => {
         const conn: Connection = createConnection(this.config);
 

packages/cubejs-mysql-driver/src/MySqlDriver.ts

@@ -23,6 +23,7 @@ import {
   DownloadTableMemoryData,
   DriverCapabilities,
   TableColumn,
+  createPoolName,
 } from '@cubejs-backend/base-driver';
 
 const GenericTypeToMySql: Record<GenericDataBaseType, string> = {
@@ -144,7 +145,9 @@ export class MySqlDriver extends BaseDriver implements DriverInterface {
       readOnly: true,
       ...restConfig,
     };
-    this.pool = new Pool('mysql', {
+
+    const poolName = createPoolName('mysql', dataSource, preAggregations);
+    this.pool = new Pool(poolName, {
       create: async () => {
         const conn: any = mysql.createConnection(this.config);
         const connect = promisify(conn.connect.bind(conn));