[pull] master from cube-js:master#201
Merged
Merged
Conversation
* wip: todos * add time_dimension_granularity_hierarchy() * implement min_granularity_for_time_dimensions * fix add_interval() for time-only intervals * fix rollup_granularity() in time dimension symbol * implement is_aligned_with_date_range() in Granularity * fix symbols factory allowing long_path member names * support custom granularities in dimension matcher * use time dimensions instead of dimensions for PreAggregation time_dimensions * fix matcher * fix make_pre_aggregation_union_source() * cargo fmt/clippy * run drivers tests for changes in tesseract * fix DimensionSymbolFactory try_new for short/long paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )