[pull] master from cube-js:master#451
Merged
Merged
Conversation
Clients can opt in via `HttpQuery.response_format = Arrow` to receive results as a binary Arrow IPC stream wrapped in a new `HttpQueryResult` flatbuffer variant, instead of the legacy `HttpResultSet` where every cell is stringified. Default stays `Legacy`, so existing clients that don't set the flag keep getting `HttpResultSet` β no behavior change for them.
parse_date_str` previously walked a 7-format `chrono::NaiveDateTime::parse_from_str` cascade. Cube's canonical wire shape is `%Y-%m-%dT%H:%M:%S%.3f` β `YYYY-MM-DDTHH:MM:SS.fff`, exactly 23 bytes β and was the 5th attempt in that cascade, so most rows reparsed the prefix 4 times before matching. Benchmark on Apple M3 Max (`cargo bench --bench transform_response`, 10k rows, master vs. this commit): | Shape (10k rows) | Before | After | Ξ | | ------------------------- | --------- | --------- | ------ | | row / cols=8 / td=1 | 22.48 ms | 15.84 ms | -29.5% | | columnar / cols=8 / td=1 | 7.76 ms | 3.08 ms | -60.3% | | row / cols=16 / td=2 | ~43 ms | 36.19 ms | -15.8% | | columnar / cols=16 / td=2 | ~16 ms | 6.11 ms | -61.8% | | columnar / cols=16 / td=0 | unchanged | unchanged | noise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? π Please sponsor : )