[pull] master from cube-js:master#459
Merged
Merged
Conversation
* Remove view-side view group assignment from docs Generated-By: mintlify-agent
β¦#10844) `DBResponseValue` had three variants but only `Primitive` was ever constructed in production. `DateTime` and `Object` existed only in tests (the latter even carried `// TODO: Is this variant still used?`). The wrapper added per-cell discriminant + alignment overhead and a dead match arm in the `transform_value` hot loop. `TransformedData::transform` columnar path: | bench | before | after | Ξ | |----------------------|-----------|-----------|--------| | columnar/c16_r10000 | 2.62 ms | 2.26 ms | β13.7% | | columnar/c16_r50000 | 17.13 ms | 13.89 ms | β18.9% | | columnar/c16_r100000 | 46.05 ms | 38.45 ms | β16.5% | | columnar/c32_r10000 | 5.89 ms | 4.81 ms | β18.3% | | columnar/c32_r50000 | 30.24 ms | 26.84 ms | β11.2% | | columnar/c64_r100000 | 121.24 ms | 108.39 ms | β10.6% | Real-shape scenarios (c16Γ100k): | scenario | before | after | Ξ | |--------------------------------------------|-----------|-----------|--------| | columnar / no_time_dim | 42.13 ms | 32.12 ms | β23.8% | | columnar / one_time_dim_day | 87.41 ms | 74.33 ms | β15.0% | | columnar / one_time_dim_custom_granularity | 93.79 ms | 79.62 ms | β15.1% | | columnar / two_time_dims | 132.90 ms | 115.98 ms | β12.7% | | vanilla / one_time_dim_day | 161.03 ms | 146.46 ms | β9.1% | | vanilla / two_time_dims | 222.80 ms | 206.43 ms | β7.3% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? π Please sponsor : )