[pull] master from cube-js:master#549
Merged
Merged
Conversation
…ping rows (#11097) * fix(cubejs-client-core): surface cubeSql error chunks instead of dropping rows The cubesql endpoint streams JSONL (schema line, then data lines), and on a post-processing failure appends a trailing `{ error }` chunk. The non-streaming `cubeSql()` parser mapped every non-schema line through `JSON.parse(d).data`, so the error line became an `undefined` phantom row and the failure was silently swallowed — callers saw a "successful" result with a null row. Classify each line and throw on an `error` chunk, mirroring how `cubeSqlStream()` already handles it. Genuine parse failures still fall back to the raw response body. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(cubejs-client-core): satisfy eslint in cubeSql error handling Drop the `no-continue` violation by inverting the loop guard, and switch the regression test's error strings to single quotes per the lint rule. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )