[pull] master from cube-js:master#555
Merged
Merged
Conversation
…t buckets (#11143) When a Databricks export bucket is configured for OIDC / workload identity there are no static credentials, but the driver passed `{ accessKeyId: '', secretAccessKey: '' }` to the S3 client unconditionally. The AWS SDK treats those empty strings as explicit credentials and the request fails with `AuthorizationHeaderMalformed: ... a non-empty Access Key (AKID) must be provided`, instead of falling back to the default provider chain (`AWS_WEB_IDENTITY_TOKEN_FILE`, IRSA, ...). Athena and BigQuery already work in this setup (Athena omits credentials when none are set; BigQuery uses GCS). This brings Databricks in line: - DatabricksDriver omits credentials across all three bucket types (S3, GCS, Azure) when none are configured, so the cloud SDK default chain / `DefaultAzureCredential` (`AZURE_FEDERATED_TOKEN_FILE`) resolves them. - base-driver `aws.fs` adds `normalizeS3ClientConfig`, which strips blank static credentials and a blank region before constructing the S3 client — protecting every S3-using driver, while leaving credential provider functions and fully-populated static credentials untouched. - base-driver `gcs.fs` adds `hasGCSCredentials`, treating empty string/object as absent so the Google SDK falls back to Application Default Credentials. Tests: base-driver unit tests cover the normalizers and verify the S3/GCS/Azure SDK clients construct without throwing when no credentials are passed; the Databricks driver test covers OIDC (no keys) and static-key S3 cases. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Eval questions can live in a single top-level agents/eval_questions.yml file or be split across agents/eval_questions/*.yml files; the parser merges all of them. Lead the authoring example with the single-file form and remove the directory-only framing. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
….md (#11147) * docs: rename Evaluate/Evaluations UI labels to Evals Match the renamed product UI: the model IDE tab and the runs sub-tab are now "Evals", a single run is an "eval run", and the action/column read "New eval"/"Eval name". Updates the section heading and image alt text to match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs: add Evals to product taxonomy and naming conventions Record Evals under the Agent node in the product taxonomy tree and add an Evals Terminology section establishing "Evals" (feature/tab/sub-tab) and "eval run" as canonical, with "Evaluate"/"Evaluation" called out as legacy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs: inline naming conventions into CLAUDE.md, drop Cursor rule We no longer use Cursor, so move the product naming conventions out of .cursor/rules/namings-rule.mdc and inline them directly into docs-mintlify/CLAUDE.md (headings demoted to nest under "Naming conventions"). Removes the @-import and the orphaned Cursor file. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs: correct eval action label to "Run eval" The button is labeled "Run eval", not "New eval". Fix the evals page and the Evals Terminology naming note. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs: rename eval-run column label to "Eval run" The runs-list column is labeled "Eval run", not "Eval name". Fix the evals page and the Evals Terminology naming note. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
rust
data source driver
cubejs-jdbc-driver
driver:athena
driver:bigquery
driver:clickhouse
driver:crate
driver:databricks
driver:dremio
driver:druid
driver:duckdb
driver:elasticsearch
driver:firebolt
driver:hive
driver:materialize
driver:mongodb
driver:mssql
driver:mysql
driver:mysql-aurora-serverless
driver:oracle
driver:pinot
driver:postgres
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )