Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,9 @@ jobs:
- db: mssql
node-version: 22.x
use_tesseract_sql_planner: true
- db: firebolt
node-version: 22.x
use_tesseract_sql_planner: true
fail-fast: false

steps:
Expand Down
6 changes: 6 additions & 0 deletions packages/cubejs-firebolt-driver/src/FireboltQuery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ export class FireboltQuery extends BaseQuery {
return new FireboltFilter(this, filter);
}

public sqlTemplates() {
const templates = super.sqlTemplates();
templates.tesseract.bool_param_cast = 'CAST({{ expr }} AS BOOLEAN)';
return templates;
}

public defaultRefreshKeyRenewalThreshold() {
return 120;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-testing-drivers/fixtures/athena.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"CUBEJS_CUBESTORE_HOST": "store",
"CUBEJS_DB_TYPE": "athena",
"CUBEJS_DB_EXPORT_BUCKET": "s3://athena-drivers-tests-preaggs/bucket",
"CUBEJS_PRE_AGGREGATIONS_SCHEMA": "drivers_tests_preaggs",
"CUBEJS_PRE_AGGREGATIONS_SCHEMA": "${DRIVERS_TESTS_CUBEJS_PRE_AGGREGATIONS_SCHEMA:-drivers_tests_preaggs}",
"CUBEJS_AWS_KEY": "${DRIVERS_TESTS_ATHENA_CUBEJS_AWS_KEY}",
"CUBEJS_AWS_SECRET": "${DRIVERS_TESTS_ATHENA_CUBEJS_AWS_SECRET}",
"CUBEJS_AWS_REGION": "us-east-1",
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-testing-drivers/fixtures/bigquery.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"CUBEJS_CUBESTORE_HOST": "store",
"CUBEJS_DB_TYPE": "bigquery",
"CUBEJS_DB_NAME": "test",
"CUBEJS_PRE_AGGREGATIONS_SCHEMA": "dev_pre_aggregations",
"CUBEJS_PRE_AGGREGATIONS_SCHEMA": "${DRIVERS_TESTS_CUBEJS_PRE_AGGREGATIONS_SCHEMA:-dev_pre_aggregations}",
"CUBEJS_DB_BQ_PROJECT_ID": "cube-open-source",
"CUBEJS_DB_BQ_CREDENTIALS": "${DRIVERS_TESTS_CUBEJS_DB_BQ_CREDENTIALS}",

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"CUBEJS_DB_DATABRICKS_TOKEN": "${DRIVERS_TESTS_CUBEJS_DB_DATABRICKS_TOKEN}",
"CUBEJS_DB_DATABRICKS_URL": "${DRIVERS_TESTS_CUBEJS_DB_DATABRICKS_URL}",
"CUBEJS_DB_DATABRICKS_ACCEPT_POLICY": "true",
"CUBEJS_PRE_AGGREGATIONS_SCHEMA": "drivers_tests_preaggs",
"CUBEJS_PRE_AGGREGATIONS_SCHEMA": "${DRIVERS_TESTS_CUBEJS_PRE_AGGREGATIONS_SCHEMA:-drivers_tests_preaggs}",
"CUBEJS_PG_SQL_PORT": "5656",
"CUBEJS_SQL_USER": "admin",
"CUBEJS_SQL_PASSWORD": "admin_password",
Expand Down
1 change: 1 addition & 0 deletions packages/cubejs-testing-drivers/fixtures/redshift.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"CUBEJS_DB_HOST": "${DRIVERS_TESTS_CUBEJS_DB_REDSHIFT_HOST}",
"CUBEJS_DB_PORT": "5439",
"CUBEJS_DB_NAME": "dev",
"CUBEJS_PRE_AGGREGATIONS_SCHEMA": "${DRIVERS_TESTS_CUBEJS_PRE_AGGREGATIONS_SCHEMA:-dev_pre_aggregations}",
"CUBEJS_DB_USER": "${DRIVERS_TESTS_CUBEJS_DB_REDSHIFT_USER}",
"CUBEJS_DB_PASS": "${DRIVERS_TESTS_CUBEJS_DB_REDSHIFT_PASS}",
"CUBEJS_DB_MAX_POOL": "2",
Expand Down
13 changes: 11 additions & 2 deletions packages/cubejs-testing-drivers/src/helpers/runEnvironment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,19 @@ export async function runEnvironment(
const { length } = val;

if (val.indexOf('${') === 0 && val.indexOf('}') === length - 1) {
const name = val.slice(2, length - 1).trim();
// Supports docker-compose style interpolation `${VAR}` and `${VAR:-default}`.
// The `:-default` fallback lets shared-cloud fixtures point a value (e.g. the
// pre-aggregations schema) at a per-run env var in CI while keeping the original
// literal as the default for local/other runs where the var is unset.
const expr = val.slice(2, length - 1).trim();
const sepIdx = expr.indexOf(':-');
const name = (sepIdx === -1 ? expr : expr.slice(0, sepIdx)).trim();
const fallback = sepIdx === -1 ? undefined : expr.slice(sepIdx + 2);
const value = process.env[name];
if (value) {
process.env[key] = process.env[name];
process.env[key] = value;
} else if (fallback !== undefined) {
process.env[key] = fallback;
} else {
throw new Error(`Env variable ${name} must be defined, because it's used as ${key}`);
}
Expand Down
Loading