[pull] master from cube-js:master#571
Merged
Merged
Conversation
The review workflow resolved the PR's head branch name and checked it out from the base repo — for fork PRs that branch only exists in the fork, so checkout failed (run 28585715254). GitHub mirrors every PR head into the base repo as refs/pull/<N>/head, readable with the workflow token, so check out that ref instead; it works uniformly for fork and same-repo PRs. Only the PR number is needed now, so the resolve step (and its `gh pr view` round-trip) is replaced by a job-level PR_NUMBER coalesce. Checkout also sets persist-credentials: false since the checked-out tree is now fork-controlled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )