Consolidate partnerDuplicatePayoutMethod into partnerDuplicateAccount (dubinc#3782)

Author: devkiran

apps/web/app/(ee)/api/cron/partners/merge-accounts/route.ts

@@ -346,7 +346,7 @@ export async function POST(req: Request) {
       where: {
         partnerId: sourcePartnerId,
         fraudEventGroup: {
-          type: FraudRuleType.partnerDuplicatePayoutMethod,
+          type: FraudRuleType.partnerDuplicateAccount,
         },
       },
       include: {
@@ -395,7 +395,7 @@ export async function POST(req: Request) {
               ]
             : []),
         ],
-        type: FraudRuleType.partnerDuplicatePayoutMethod,
+        type: FraudRuleType.partnerDuplicateAccount,
       },
       resolutionReason:
         "Automatically resolved because partners with duplicate payout methods were merged. No other partners share this payout method.",

apps/web/lib/api/fraud/constants.ts

@@ -48,24 +48,14 @@ export const FRAUD_RULES: FraudRuleInfo[] = [
     configurable: true,
   },
   {
-    type: "partnerDuplicatePayoutMethod",
+    type: "partnerDuplicateAccount",
     name: "Duplicate account detected",
     description:
       "This partner was flagged by our system for having 2 or more Dub accounts. Please review to prevent abuse of program restrictions, caps, or bonuses.",
     scope: "partner",
     severity: "high",
     configurable: true,
   },
-  // Not visible in the UI
-  {
-    type: "partnerDuplicateAccount",
-    name: "Duplicate account detected",
-    description:
-      "This partner was flagged by our system for having 2 or more Dub accounts. Please review to prevent abuse of program restrictions, caps, or bonuses.",
-    scope: "partner",
-    severity: "low",
-    configurable: false,
-  },
   {
     type: "partnerEmailDomainMismatch",
     name: "Email domain mismatch with website",

apps/web/lib/api/fraud/detect-duplicate-identity-fraud.ts

@@ -72,7 +72,7 @@ export async function detectDuplicateIdentityFraud({
   programEnrollments = programEnrollments.filter((enrollment) =>
     isFraudRuleEnabled({
       fraudRules: enrollment.program.fraudRules,
-      ruleType: FraudRuleType.partnerDuplicatePayoutMethod, // TODO: Change to partnerDuplicateAccount
+      ruleType: FraudRuleType.partnerDuplicateAccount,
     }),
   );
 

apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts

@@ -44,11 +44,11 @@ export async function detectDuplicatePayoutMethodFraud({
     return;
   }
 
-  // Filter out program enrollments where the partnerDuplicatePayoutMethod rule is disabled
+  // Filter out program enrollments where the partnerDuplicateAccount rule is disabled
   programEnrollments = programEnrollments.filter((enrollment) =>
     isFraudRuleEnabled({
       fraudRules: enrollment.program.fraudRules,
-      ruleType: FraudRuleType.partnerDuplicatePayoutMethod,
+      ruleType: FraudRuleType.partnerDuplicateAccount,
     }),
   );
 
@@ -89,7 +89,7 @@ export async function detectDuplicatePayoutMethodFraud({
         fraudEvents.push({
           programId,
           partnerId: sourcePartner.partnerId,
-          type: FraudRuleType.partnerDuplicatePayoutMethod,
+          type: FraudRuleType.partnerDuplicateAccount,
           metadata: {
             ...(payoutMethodHash ? { payoutMethodHash } : {}),
             ...(cryptoWalletAddress ? { cryptoWalletAddress } : {}),

apps/web/lib/api/fraud/detect-record-fraud-application.ts

@@ -33,7 +33,7 @@ export async function detectAndRecordFraudApplication({
   if (
     isFraudRuleEnabled({
       fraudRules,
-      ruleType: FraudRuleType.partnerDuplicatePayoutMethod,
+      ruleType: FraudRuleType.partnerDuplicateAccount,
     })
   ) {
     const { payoutMethodHash, cryptoWalletAddress } = partner;
@@ -81,7 +81,7 @@ export async function detectAndRecordFraudApplication({
             fraudEvents.push({
               programId: program.id,
               partnerId: sourcePartner.id,
-              type: FraudRuleType.partnerDuplicatePayoutMethod,
+              type: FraudRuleType.partnerDuplicateAccount,
               metadata: {
                 ...(payoutMethodHash ? { payoutMethodHash } : {}),
                 ...(cryptoWalletAddress ? { cryptoWalletAddress } : {}),

apps/web/lib/api/fraud/get-partner-application-risks.ts

@@ -21,7 +21,7 @@ export async function getPartnerApplicationRisks({
       partnerId: partner.id,
       status: "pending",
       type: {
-        in: ["partnerCrossProgramBan", "partnerDuplicatePayoutMethod"],
+        in: ["partnerCrossProgramBan", "partnerDuplicateAccount"],
       },
     },
   });
@@ -30,13 +30,13 @@ export async function getPartnerApplicationRisks({
     (group) => group.type === "partnerCrossProgramBan",
   );
 
-  const hasDuplicatePayoutMethod = fraudGroups.some(
-    (group) => group.type === "partnerDuplicatePayoutMethod",
+  const hasDuplicateAccounts = fraudGroups.some(
+    (group) => group.type === "partnerDuplicateAccount",
   );
 
   const risksDetected: Partial<Record<ExtendedFraudRuleType, boolean>> = {
     partnerCrossProgramBan: hasCrossProgramBan,
-    partnerDuplicatePayoutMethod: hasDuplicatePayoutMethod,
+    partnerDuplicateAccount: hasDuplicateAccounts,
     partnerEmailDomainMismatch: checkPartnerEmailDomainMismatch(partner),
     partnerEmailMasked: checkPartnerEmailMasked(partner),
     partnerNoSocialLinks: checkPartnerNoSocialLinks(partner),

apps/web/lib/api/fraud/utils.ts

@@ -89,12 +89,15 @@ function getIdentityFieldsForFraudEvent({
         customerId,
       };
 
-    case "partnerDuplicatePayoutMethod":
     case "partnerDuplicateAccount":
       return {
         duplicatePartnerId: eventMetadata?.duplicatePartnerId,
       };
 
+    // Note: This will be removed in the next PR
+    case "partnerDuplicatePayoutMethod":
+      throw new Error("Fraud rule is no longer supported.");
+
     case "partnerCrossProgramBan":
       if (!sourceProgramId) {
         throw new Error(`sourceProgramId is required for ${type} fraud rule.`);
@@ -136,10 +139,7 @@ export function getPartnerIdForFraudEvent(
 ) {
   const metadata = event.metadata as Record<string, string> | undefined;
 
-  if (
-    event.type === "partnerDuplicatePayoutMethod" ||
-    event.type === "partnerDuplicateAccount"
-  ) {
+  if (event.type === "partnerDuplicateAccount") {
     return metadata?.duplicatePartnerId ?? event.partnerId;
   }
 

apps/web/lib/zod/schemas/fraud.ts

@@ -251,7 +251,6 @@ export const updateFraudRuleSettingsSchema = z.object({
   customerEmailMatch: toggleOnlyFraudRuleSchema,
   customerEmailSuspiciousDomain: toggleOnlyFraudRuleSchema,
   partnerCrossProgramBan: toggleOnlyFraudRuleSchema,
-  partnerDuplicatePayoutMethod: toggleOnlyFraudRuleSchema,
   partnerDuplicateAccount: toggleOnlyFraudRuleSchema,
 });
 
@@ -326,8 +325,6 @@ export const fraudEventSchemas = {
     }),
   }),
 
-  partnerDuplicatePayoutMethod: baseFraudEventSchema,
-
   partnerDuplicateAccount: baseFraudEventSchema,
 };
 

apps/web/scripts/migrations/consolidate-duplicate-account-fraud.ts

@@ -0,0 +1,41 @@
+import { prisma } from "@dub/prisma";
+import "dotenv-flow/config";
+
+async function main() {
+  // Migrate FraudRule
+  const { count } = await prisma.fraudRule.updateMany({
+    where: {
+      type: "partnerDuplicatePayoutMethod",
+    },
+    data: {
+      type: "partnerDuplicateAccount",
+    },
+  });
+
+  console.log(
+    `Updated ${count} fraud rules from partnerDuplicatePayoutMethod to partnerDuplicateAccount`,
+  );
+
+  // Migrate FraudEventGroup
+  while (true) {
+    const { count } = await prisma.fraudEventGroup.updateMany({
+      where: {
+        type: "partnerDuplicatePayoutMethod",
+      },
+      data: {
+        type: "partnerDuplicateAccount",
+      },
+      limit: 100,
+    });
+
+    console.log(
+      `Updated ${count} fraud event groups from partnerDuplicatePayoutMethod to partnerDuplicateAccount`,
+    );
+
+    if (count === 0) {
+      break;
+    }
+  }
+}
+
+main();

apps/web/ui/partners/fraud-risks/fraud-events-tables/fraud-partner-info-table.tsx

@@ -10,7 +10,7 @@ import Link from "next/link";
 import * as z from "zod/v4";
 
 type EventDataProps = z.infer<
-  (typeof fraudEventSchemas)["partnerDuplicatePayoutMethod"]
+  (typeof fraudEventSchemas)["partnerDuplicateAccount"]
 >;
 
 export function FraudPartnerInfoTable() {