Fix partnerCrossProgramBan UX (dubinc#3700)

Co-authored-by: Kiran K <kiran@dub.co>

Author: steven-tey

apps/web/app/(ee)/api/cron/partners/ban/route.ts

@@ -1,5 +1,4 @@
 import { deleteDiscountCodes } from "@/lib/api/discounts/delete-discount-code";
-import { reportCrossProgramBanToNetwork } from "@/lib/api/fraud/report-cross-program-ban-to-network";
 import { linkCache } from "@/lib/api/links/cache";
 import { includeTags } from "@/lib/api/links/include-tags";
 import { syncTotalCommissions } from "@/lib/api/partners/sync-total-commissions";
@@ -136,13 +135,6 @@ export const POST = withCron(async ({ rawBody }) => {
     deleteDiscountCodes(links.map((link) => link.discountCode)),
   ]);
 
-  await reportCrossProgramBanToNetwork({
-    partnerId,
-    programId,
-    bannedReason: programEnrollment.bannedReason,
-    bannedAt: programEnrollment.bannedAt,
-  });
-
   // Send email
   if (partner.email) {
     const program = await prisma.program.findUniqueOrThrow({

apps/web/lib/api/fraud/detect-record-fraud-application.ts

@@ -28,46 +28,6 @@ export async function detectAndRecordFraudApplication({
     },
   });
 
-  // Check if partner has been banned in other programs
-  // indicates cross-program fraud risk
-  if (
-    isFraudRuleEnabled({
-      fraudRules,
-      ruleType: FraudRuleType.partnerCrossProgramBan,
-    })
-  ) {
-    const bannedProgramEnrollments = await prisma.programEnrollment.findMany({
-      where: {
-        partnerId: partner.id,
-        programId: {
-          not: program.id,
-        },
-        status: "banned",
-      },
-      select: {
-        programId: true,
-        bannedReason: true,
-        bannedAt: true,
-      },
-    });
-
-    // Create a fraud event for each program that banned the partner
-    if (bannedProgramEnrollments.length > 0) {
-      for (const bannedEnrollment of bannedProgramEnrollments) {
-        fraudEvents.push({
-          programId: program.id,
-          partnerId: partner.id,
-          type: FraudRuleType.partnerCrossProgramBan,
-          sourceProgramId: bannedEnrollment.programId,
-          metadata: {
-            bannedReason: bannedEnrollment.bannedReason,
-            bannedAt: bannedEnrollment.bannedAt,
-          },
-        });
-      }
-    }
-  }
-
   // Check if partner shares the same payoutMethodHash or cryptoWalletAddress with other partners
   // indicates potential duplicate account fraud
   if (

…/web/scripts/misc/remove-fraud-events.ts …misc/remove-paid-traffic-fraud-events.tsapps/web/scripts/misc/remove-fraud-events.ts renamed to apps/web/scripts/misc/remove-paid-traffic-fraud-events.ts apps/web/scripts/misc/remove-fraud-events.ts renamed to apps/web/scripts/misc/remove-paid-traffic-fraud-events.ts

@@ -0,0 +1,52 @@
+import { prisma } from "@dub/prisma";
+import "dotenv-flow/config";
+
+// script to remove fraud events for certain campaign ids
+async function main() {
+  const fraudEventsToRemove = await prisma.fraudEvent.findMany({
+    where: {
+      fraudEventGroup: {
+        type: "partnerCrossProgramBan",
+        status: "pending",
+      },
+    },
+  });
+
+  console.log(`Found ${fraudEventsToRemove.length} fraud events to remove`);
+
+  const deleted = await prisma.fraudEvent.deleteMany({
+    where: {
+      id: {
+        in: fraudEventsToRemove.map((event) => event.id),
+      },
+    },
+  });
+
+  console.log(`Removed ${deleted.count} fraud events`);
+
+  const fraudEventGroupsWithNoEvents = await prisma.fraudEventGroup.findMany({
+    where: {
+      type: "partnerCrossProgramBan",
+      status: "pending",
+      fraudEvents: {
+        none: {},
+      },
+    },
+  });
+
+  console.log(
+    `Found ${fraudEventGroupsWithNoEvents.length} fraud event groups with no events`,
+  );
+
+  const deletedGroups = await prisma.fraudEventGroup.deleteMany({
+    where: {
+      id: {
+        in: fraudEventGroupsWithNoEvents.map((group) => group.id),
+      },
+    },
+  });
+
+  console.log(`Removed ${deletedGroups.count} fraud event groups`);
+}
+
+main();