Skip to content

[pull] main from dubinc:main #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Mar 31, 2026
Merged

[pull] main from dubinc:main #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1855358
Update is-generic-email.ts
steven-tey Mar 31, 2026
4b050e2
fix PartnerApplicationRiskSummaryUpsell
steven-tey Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/web/lib/is-generic-email.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const GENERIC_EMAIL_DOMAINS = [
"email.cz",
"email.de",
"t-online.de",
"sina.com",
];

const GENERIC_EMAIL_DOMAIN_PREFIXES = [
Expand Down
4 changes: 2 additions & 2 deletions apps/web/lib/swr/use-partner-application-risks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { FRAUD_RULES } from "@/lib/api/fraud/constants";
import { ExtendedFraudRuleType, FraudSeverity } from "@/lib/types";
import { fetcher } from "@dub/utils";
import { useMemo } from "react";
import useSWR from "swr";
import useSWRImmutable from "swr/immutable";
import useWorkspace from "./use-workspace";

type FraudRisksResponse = {
Expand All @@ -20,7 +20,7 @@ export function usePartnerApplicationRisks({
const { id: workspaceId } = useWorkspace();
const { partnerId } = filters;

const { data, isLoading, error } = useSWR<FraudRisksResponse>(
const { data, isLoading, error } = useSWRImmutable<FraudRisksResponse>(
enabled && partnerId && workspaceId
? `/api/partners/${partnerId}/application-risks?workspaceId=${workspaceId}`
: null,
Expand Down
8 changes: 4 additions & 4 deletions apps/web/ui/partners/fraud-risks/partner-application-risk-summary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ export function PartnerApplicationRiskSummary({

const { canManageFraudEvents } = getPlanCapabilities(plan);

if (!canManageFraudEvents && !isLoading) {
return <PartnerApplicationRiskSummaryUpsell />;
}

if (isLoading || triggeredFraudRules.length === 0) {
return null;
}

if (!canManageFraudEvents) {
return <PartnerApplicationRiskSummaryUpsell />;
}

return (
<>
<div className="flex flex-col gap-4 p-4">
Expand Down
Loading