Load env vars from a node hook so they're loaded before the logging and tracing init

Author: danielcampagnolitg

src/agent/completionHandlerRegistry.ts

@@ -1,16 +1,16 @@
 import { ConsoleCompletedHandler } from '#agent/autonomous/agentCompletion';
-import { SlackChatBotService } from '#modules/slack/slackChatBotService';
 import { logger } from '#o11y/logger';
 import { GitLabNoteCompletedHandler } from '#routes/webhooks/gitlab/gitlabNoteHandler';
 import type { AgentCompleted } from '#shared/agent/agent.model';
 
 // Use a Map for easier addition/removal during tests
 let handlersMap = new Map<string, new () => AgentCompleted>();
 
-// Initialize with default handlers
-handlersMap.set(new ConsoleCompletedHandler().agentCompletedHandlerId(), ConsoleCompletedHandler);
-handlersMap.set(new SlackChatBotService().agentCompletedHandlerId(), SlackChatBotService);
-handlersMap.set(new GitLabNoteCompletedHandler().agentCompletedHandlerId(), GitLabNoteCompletedHandler);
+function initHandlers() {
+	// Initialize with default handlers
+	handlersMap.set(new ConsoleCompletedHandler().agentCompletedHandlerId(), ConsoleCompletedHandler);
+	handlersMap.set(new GitLabNoteCompletedHandler().agentCompletedHandlerId(), GitLabNoteCompletedHandler);
+}
 
 /**
  * Return the AgentCompleted callback object from its id.
@@ -20,6 +20,8 @@ handlersMap.set(new GitLabNoteCompletedHandler().agentCompletedHandlerId(), GitL
 export function getCompletedHandler(handlerId: string): AgentCompleted | null {
 	if (!handlerId) return null;
 
+	if (handlersMap.size === 0) initHandlers();
+
 	const HandlerCtor = handlersMap.get(handlerId);
 	if (HandlerCtor) return new HandlerCtor();
 
@@ -47,5 +49,4 @@ export function clearCompletedHandlers(): void {
 	handlersMap = new Map<string, new () => AgentCompleted>();
 	// Re-initialize with default handlers
 	handlersMap.set(new ConsoleCompletedHandler().agentCompletedHandlerId(), ConsoleCompletedHandler);
-	handlersMap.set(new SlackChatBotService().agentCompletedHandlerId(), SlackChatBotService);
 }

src/cli/agent.ts

@@ -14,11 +14,9 @@ import { logger } from '#o11y/logger';
 import type { AgentContext } from '#shared/agent/agent.model';
 import { registerErrorHandlers } from '../errorHandlers';
 import { parseProcessArgs, saveAgentId } from './cli';
-import { loadCliEnvironment } from './envLoader';
 import { resolveFunctionClasses } from './functionAliases';
 
 export async function main(): Promise<void> {
-	loadCliEnvironment();
 	registerErrorHandlers();
 	await initApplicationContext();
 	const llms = defaultLLMs();

src/cli/chat.ts

@@ -9,11 +9,9 @@ import { getMarkdownFormatPrompt } from '#routes/chat/chatPromptUtils';
 import { LLM, LlmMessage, UserContentExt, contentText, messageText, user } from '#shared/llm/llm.model';
 import { currentUser } from '#user/userContext';
 import { parseProcessArgs, saveAgentId } from './cli';
-import { loadCliEnvironment } from './envLoader';
 import { LLM_CLI_ALIAS } from './llmAliases';
 
 async function main() {
-	loadCliEnvironment();
 	await initApplicationContext();
 
 	const { initialPrompt: rawPrompt, resumeAgentId, flags } = parseProcessArgs();

src/cli/code.ts

@@ -11,11 +11,9 @@ import { contentText, messageText } from '#shared/llm/llm.model';
 import { CodeEditingAgent } from '#swe/codeEditingAgent';
 import { beep } from '#utils/beep';
 import { parseProcessArgs, saveAgentId } from './cli';
-import { loadCliEnvironment } from './envLoader';
 import { parsePromptWithImages } from './promptParser';
 
 async function main() {
-	loadCliEnvironment();
 	await initApplicationContext();
 	const agentLlms: AgentLLMs = defaultLLMs();
 

src/cli/codeAgent.ts

@@ -21,7 +21,6 @@ import { CodeFunctions } from '#swe/codeFunctions';
 import { MorphEditor } from '#swe/morph/morphEditor';
 import { registerErrorHandlers } from '../errorHandlers';
 import { parseProcessArgs, saveAgentId } from './cli';
-import { loadCliEnvironment } from './envLoader';
 import { resolveFunctionClasses } from './functionAliases';
 
 async function resumeAgent(resumeAgentId: string, initialPrompt: string) {
@@ -44,7 +43,6 @@ async function resumeAgent(resumeAgentId: string, initialPrompt: string) {
 }
 
 export async function main(): Promise<void> {
-	loadCliEnvironment();
 	registerErrorHandlers();
 	await initApplicationContext();
 	const llms = defaultLLMs();

src/cli/commit.ts

@@ -5,10 +5,8 @@ import { shutdownTrace } from '#fastify/trace-init/trace-init';
 import { Git } from '#functions/scm/git';
 import { FileSystemRead } from '#functions/storage/fileSystemRead';
 import { defaultLLMs } from '#llm/services/defaultLlms';
-import { loadCliEnvironment } from './envLoader';
 
 async function main() {
-	loadCliEnvironment();
 	await initApplicationContext();
 	console.log('Commit command starting...');
 

src/cli/debate.ts

@@ -12,11 +12,9 @@ import { logger } from '#o11y/logger';
 import type { AgentLLMs } from '#shared/agent/agent.model';
 import { messageText } from '#shared/llm/llm.model';
 import { parseProcessArgs } from './cli';
-import { loadCliEnvironment } from './envLoader';
 import { parsePromptWithImages } from './promptParser';
 
 async function main() {
-	loadCliEnvironment();
 	await initApplicationContext();
 	const agentLLMs: AgentLLMs = defaultLLMs();
 	const { initialPrompt: rawPrompt, resumeAgentId, flags } = parseProcessArgs();

src/cli/easy.ts

@@ -9,14 +9,12 @@ import { mockLLMs } from '#llm/services/mock-llm';
 import { vertexGemini_2_5_Flash } from '#llm/services/vertexai';
 import type { AgentContext } from '#shared/agent/agent.model';
 import { parseProcessArgs } from './cli';
-import { loadCliEnvironment } from './envLoader';
 
 // See https://arxiv.org/html/2405.19616v1 https://github.com/autogenai/easy-problems-that-llms-get-wrong
 // Usage:
 // npm run easy
 
 async function main() {
-	loadCliEnvironment();
 	await initApplicationContext();
 
 	const context: AgentContext = createContext({

src/cli/envLoader.ts

@@ -4,10 +4,8 @@
  * When using git worktrees enables using the local.env from the main repository
  * Extracted from startLocal.ts to be shared across all CLI tools.
  */
-
 import { existsSync, readFileSync } from 'node:fs';
 import { isAbsolute, resolve } from 'node:path';
-import { logger } from '#o11y/logger';
 
 interface ResolveEnvFileOptions {
 	envFile?: string | null;
@@ -21,6 +19,8 @@ interface ApplyEnvOptions {
 
 type ParsedEnv = Record<string, string>;
 
+export let loadedEnvFilePath: string | undefined;
+
 /**
  * Builds an absolute path from a potential relative path.
  * @param value The path value (can be null or undefined).
@@ -125,9 +125,12 @@ export function applyEnvFile(filePath: string, options: ApplyEnvOptions = {}): v
 export function loadCliEnvironment(options: ApplyEnvOptions = {}): void {
 	try {
 		const envFilePath = resolveEnvFilePath();
+		loadedEnvFilePath = envFilePath;
 		applyEnvFile(envFilePath, options);
-		logger.debug(`Loaded environment from ${envFilePath}`);
+		console.log(`Loaded environment from ${envFilePath}`);
 	} catch (err) {
-		logger.debug(err, 'No environment file found; continuing with existing process.env');
+		console.log(err, 'No environment file found; continuing with existing process.env');
 	}
 }
+
+loadCliEnvironment();

src/cli/export.ts

@@ -7,15 +7,13 @@ import micromatch from 'micromatch';
 import { FileSystemService } from '#functions/storage/fileSystemService';
 import { countTokens } from '#llm/tokens';
 import { logger } from '#o11y/logger';
-import { loadCliEnvironment } from './envLoader';
 
 /**
  * If there are no arguments then only write the exported contents to the console
  * If there is the -v arg then write the additional debug info
  * If there is the -f arg write it to a file. Default to export.xml. If a value is provided, e.g. -f=export2.xml then write to export2.xml
  */
 async function main() {
-	loadCliEnvironment();
 	const fileSystemService = new FileSystemService();
 	const basePath = fileSystemService.getBasePath();