Skip to content

Commit 053d6e0

Browse files
authored
fix: Client crash on missing proper attachments.fields (RocketChat#37147)
1 parent 180154b commit 053d6e0

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

.changeset/chilled-pans-unite.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@rocket.chat/meteor': patch
3+
---
4+
5+
Fixes client crash on invalid message attachment fields payload.

apps/meteor/client/components/message/content/attachments/DefaultAttachment.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,12 @@ const DefaultAttachment = (attachment: DefaultAttachmentProps): ReactElement =>
8686

8787
return {
8888
...rest,
89-
title: <MarkdownText variant='inline' parseEmoji content={title.replace(/(.*)/g, (line: string) => `${line} `)} />,
90-
value: <MarkdownText variant='inline' parseEmoji content={value.replace(/(.*)/g, (line: string) => `${line} `)} />,
89+
title: title ? (
90+
<MarkdownText variant='inline' parseEmoji content={title.replace(/(.*)/g, (line: string) => `${line} `)} />
91+
) : null,
92+
value: value ? (
93+
<MarkdownText variant='inline' parseEmoji content={value.replace(/(.*)/g, (line: string) => `${line} `)} />
94+
) : null,
9195
};
9296
})}
9397
/>

0 commit comments

Comments
 (0)