fix: server crashes if drachtio connection is lost mid-call (RocketChat#40197)

Author: pierre-lehnen-rc

.changeset/witty-ravens-end.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/media-calls': minor
+---
+
+Fixes a server error when Drachtio connection is lost while a SIP call is active

.yarn/patches/drachtio-srf-npm-5.0.12-b0b1afaad6.patch

@@ -1,7 +1,16 @@
 diff --git a/lib/@types/index.d.ts b/lib/@types/index.d.ts
-index f71a82f458c1432202be8d4585fc70ba94bee4a4..b874ee9e1fa8a051f06d4824fc12161acfadb78a 100644
+index f71a82f458c1432202be8d4585fc70ba94bee4a4..2ad273d1efcaaa54b0a1326ff1c15b6cfc199be3 100644
 --- a/lib/@types/index.d.ts
 +++ b/lib/@types/index.d.ts
+@@ -101,7 +101,7 @@ declare namespace Srf {
+     local: { uri: string; sdp: string; };
+     remote: { uri: string; sdp: string; };
+     req: SrfRequest;
+-    destroy(opts?: { headers: Record<string, string>; }, callback?: (err: any, msg: SrfRequest) => void): void;
++    destroy(opts?: { headers: Record<string, string>; }, callback?: (err: any, msg: SrfRequest) => void): Promise<void>;
+     modify(sdp: string, opts?: { noAck: boolean }): Promise<string>;
+     modify(opts: { noAck: boolean }): Promise<string>;
+     modify(sdp: string, opts?: { noAck: boolean }, callback?: (err: any, msg: SrfResponse) => void): void;
 @@ -119,12 +119,12 @@ declare namespace Srf {
      on(messageType: "modify", callback: (req: SrfRequest, res: SrfResponse) => void): void;
      once(messageType: string, callback: (msg: SrfResponse) => void): void;

ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts

@@ -298,7 +298,11 @@ export class IncomingSipCall extends BaseSipCall {
 		this.lastCallState = 'hangup';
 
 		if (sipDialog) {
-			sipDialog.destroy();
+			try {
+				await sipDialog.destroy();
+			} catch (err) {
+				logger.error({ msg: 'Failed to destroy SIP dialog', err, method: 'IncomingSipCall.processEndedCall' });
+			}
 		}
 	}
 

ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts

@@ -407,7 +407,11 @@ export class OutgoingSipCall extends BaseSipCall {
 		this.lastCallState = 'hangup';
 
 		if (sipDialog) {
-			sipDialog.destroy();
+			try {
+				await sipDialog.destroy();
+			} catch (err) {
+				logger.error({ msg: 'Failed to destroy SIP dialog', err, method: 'OutgoingSipCall.processEndedCall' });
+			}
 		}
 	}
 

yarn.lock

@@ -20666,7 +20666,7 @@ __metadata:
 
 "drachtio-srf@patch:drachtio-srf@npm%3A5.0.12#~/.yarn/patches/drachtio-srf-npm-5.0.12-b0b1afaad6.patch":
   version: 5.0.12
-  resolution: "drachtio-srf@patch:drachtio-srf@npm%3A5.0.12#~/.yarn/patches/drachtio-srf-npm-5.0.12-b0b1afaad6.patch::version=5.0.12&hash=1f708c"
+  resolution: "drachtio-srf@patch:drachtio-srf@npm%3A5.0.12#~/.yarn/patches/drachtio-srf-npm-5.0.12-b0b1afaad6.patch::version=5.0.12&hash=cb2b94"
   dependencies:
     debug: "npm:^3.2.7"
     delegates: "npm:^0.1.0"
@@ -20678,7 +20678,7 @@ __metadata:
     sip-status: "npm:^0.1.0"
     utils-merge: "npm:^1.0.0"
     uuid-random: "npm:^1.3.2"
-  checksum: 10/ed791d8c614fa409b55cac896ac36cf4b3930dcb29c5e24a5be964e690c62707a48035d1482d7b79d420b2c4623581f6bfa301b06918b6b9a11ab73a5f297147
+  checksum: 10/c05e197e4f1b2bd93e8cc85356207f2b62fcd764447cbbf895d1876ad0d8aa6e3ef84f12734f91b922aa9bb5d542ecf37d703d5a361af2536833a93eb40544b9
   languageName: node
   linkType: hard