fix: missing validation for external members (RocketChat#37050)

Author: juliajforesti

.changeset/rotten-dolphins-sort.md

@@ -0,0 +1,6 @@
+---
+'@rocket.chat/i18n': patch
+'@rocket.chat/meteor': patch
+---
+
+Adds a validation to external users when creating a channel that is not federated

apps/meteor/client/NavBarV2/NavBarPagesGroup/actions/CreateChannelModal.tsx

@@ -60,6 +60,8 @@ const getFederationHintKey = (licenseModule: ReturnType<typeof useHasLicenseModu
 	return 'Federation_Matrix_Federated_Description';
 };
 
+const hasExternalMembers = (members: string[]): boolean => members.some((member) => member.startsWith('@'));
+
 const CreateChannelModal = ({ teamId = '', onClose, reload }: CreateChannelModalProps) => {
 	const t = useTranslation();
 	const canSetReadOnly = usePermissionWithScopedRoles('set-readonly', ['owner']);
@@ -237,10 +239,19 @@ const CreateChannelModal = ({ teamId = '', onClose, reload }: CreateChannelModal
 						<Controller
 							control={control}
 							name='members'
+							rules={{
+								validate: (members) =>
+									!federated && hasExternalMembers(members) ? t('You_cannot_add_external_users_to_non_federated_room') : true,
+							}}
 							render={({ field: { onChange, value } }): ReactElement => (
 								<UserAutoCompleteMultipleFederated id={addMembersId} value={value} onChange={onChange} placeholder={t('Add_people')} />
 							)}
 						/>
+						{errors.members && (
+							<FieldError aria-live='assertive' id={`${addMembersId}-error`}>
+								{errors.members.message}
+							</FieldError>
+						)}
 					</Field>
 					<Field>
 						<FieldRow>

apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx

@@ -62,6 +62,8 @@ const getFederationHintKey = (licenseModule: ReturnType<typeof useHasLicenseModu
 	return 'Federation_Matrix_Federated_Description';
 };
 
+const hasExternalMembers = (members: string[]): boolean => members.some((member) => member.startsWith('@'));
+
 const CreateChannelModal = ({ teamId = '', mainRoom, onClose, reload }: CreateChannelModalProps): ReactElement => {
 	const t = useTranslation();
 	const canSetReadOnly = usePermissionWithScopedRoles('set-readonly', ['owner']);
@@ -241,10 +243,19 @@ const CreateChannelModal = ({ teamId = '', mainRoom, onClose, reload }: CreateCh
 						<Controller
 							control={control}
 							name='members'
+							rules={{
+								validate: (members) =>
+									!federated && hasExternalMembers(members) ? t('You_cannot_add_external_users_to_non_federated_room') : true,
+							}}
 							render={({ field: { onChange, value } }): ReactElement => (
 								<UserAutoCompleteMultipleFederated id={addMembersId} value={value} onChange={onChange} placeholder={t('Add_people')} />
 							)}
 						/>
+						{errors.members && (
+							<FieldError aria-live='assertive' id={`${addMembersId}-error`}>
+								{errors.members.message}
+							</FieldError>
+						)}
 					</Field>
 					<Field>
 						<FieldRow>

packages/i18n/src/locales/en.i18n.json

@@ -7034,5 +7034,6 @@
   "__usernames__and__count__more_joined": "{{usernames}} and {{count}} more joined",
   "__usernames__joined": "{{usernames}} joined",
   "__usersCount__joined": "{{count}} joined",
-  "__usersCount__people_will_be_invited": "{{usersCount}} people will be invited"
-}
+  "__usersCount__people_will_be_invited": "{{usersCount}} people will be invited",
+  "You_cannot_add_external_users_to_non_federated_room": "You cannot add external users to a non-federated room"
+}