fix: ReadableStream not handling error properly (RocketChat#38081)

Author: dougfabris

.changeset/early-dots-leave.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue where cancelling a file upload results in an uncaught exception

apps/meteor/app/api/server/lib/getUploadFormData.spec.ts

@@ -12,6 +12,7 @@ const createMockRequest = (
 		content: string | Buffer;
 		mimetype?: string;
 	},
+	options: { simulateError?: boolean } = {},
 ): Request => {
 	const boundary = '----WebKitFormBoundary7MA4YWxkTrZu0gW';
 	const parts: string[] = [];
@@ -40,6 +41,10 @@ const createMockRequest = (
 		},
 		body: new ReadableStream({
 			async pull(controller) {
+				if (options.simulateError) {
+					controller.error(new Error('aborted'));
+					return;
+				}
 				controller.enqueue(buffer);
 				controller.close();
 			},
@@ -177,4 +182,15 @@ describe('getUploadFormData', () => {
 			expect((error as Error).message).to.equal('[error-file-too-large]');
 		}
 	});
+
+	it('should handle an aborted request stream', async () => {
+		const mockRequest = createMockRequest({}, undefined, { simulateError: true });
+
+		try {
+			await getUploadFormData({ request: mockRequest }, { fileOptional: true });
+			throw new Error('Expected function to throw');
+		} catch (error) {
+			expect((error as Error).message).to.equal('aborted');
+		}
+	});
 });

apps/meteor/app/api/server/lib/getUploadFormData.ts

@@ -165,7 +165,9 @@ export async function getUploadFormData<
 	});
 
 	// Unclear why typescript complains that the ReadableStream from request.body is incompatible here
-	Readable.fromWeb(request.body satisfies ReadableStream).pipe(bb);
+	Readable.fromWeb(request.body satisfies ReadableStream)
+		.on('error', (err) => reject(err))
+		.pipe(bb);
 
 	return resultPromise;
 }