fix: wrong sound on Omnichannel continuous notification (RocketChat#37042)

Author: juliajforesti

.changeset/grumpy-points-deliver.md

@@ -0,0 +1,6 @@
+---
+'@rocket.chat/ui-contexts': patch
+'@rocket.chat/meteor': patch
+---
+
+Adjusts custom sound loop on omnichannel continuous notification to play `New room` loop instead of `New message` loop

apps/meteor/client/hooks/useOmnichannelContinuousSoundNotification.ts

@@ -19,7 +19,7 @@ export const useOmnichannelContinuousSoundNotification = <T>(queue: T[]) => {
 			return;
 		}
 
-		notificationSounds.playNewMessageLoop();
+		notificationSounds.playNewRoomLoop();
 
 		return () => {
 			notificationSounds.stopNewRoom();

apps/meteor/client/providers/CustomSoundProvider/CustomSoundProvider.tsx

@@ -75,10 +75,10 @@ const CustomSoundProvider = ({ children }: CustomSoundProviderProps) => {
 	const contextValue = useMemo(() => {
 		const notificationSounds = {
 			playNewRoom: () => play(newRoomNotification, { loop: false, volume: formatVolume(notificationsSoundVolume) }),
+			playNewRoomLoop: () => play(newRoomNotification, { loop: true, volume: formatVolume(notificationsSoundVolume) }),
 			playNewMessage: () => play(newMessageNotification, { loop: false, volume: formatVolume(notificationsSoundVolume) }),
 			playNewMessageCustom: (soundId: ICustomSound['_id']) =>
 				play(soundId, { loop: false, volume: formatVolume(notificationsSoundVolume) }),
-			playNewMessageLoop: () => play(newMessageNotification, { loop: true, volume: formatVolume(notificationsSoundVolume) }),
 			stopNewRoom: () => stop(newRoomNotification),
 			stopNewMessage: () => stop(newMessageNotification),
 		};

packages/ui-contexts/src/CustomSoundContext.ts

@@ -30,8 +30,8 @@ export type CustomSoundContextValue = {
 	};
 	notificationSounds: {
 		playNewRoom: () => void;
+		playNewRoomLoop: () => void;
 		playNewMessage: () => void;
-		playNewMessageLoop: () => void;
 		stopNewRoom: () => void;
 		stopNewMessage: () => void;
 		playNewMessageCustom: (soundId: ICustomSound['_id']) => void;
@@ -60,8 +60,8 @@ export const CustomSoundContext = createContext<CustomSoundContextValue>({
 	},
 	notificationSounds: {
 		playNewRoom: () => undefined,
+		playNewRoomLoop: () => undefined,
 		playNewMessage: () => undefined,
-		playNewMessageLoop: () => undefined,
 		stopNewRoom: () => undefined,
 		stopNewMessage: () => undefined,
 		playNewMessageCustom: () => undefined,