test: Notification sounds tests running before room is ready (RocketChat#39988)

Author: dougfabris

apps/meteor/tests/e2e/notification-sounds.spec.ts

@@ -18,6 +18,7 @@ test.describe.serial('Notification Sounds', () => {
 	let targetChannel: string;
 	let targetChannelId: string;
 	let poHomeChannel: HomeChannel;
+	let user1PoHomeChannel: HomeChannel;
 	let user1Page: Page;
 
 	test.beforeAll(async ({ api }) => {
@@ -34,9 +35,12 @@ test.describe.serial('Notification Sounds', () => {
 
 	test.beforeEach(async ({ page, browser }) => {
 		poHomeChannel = new HomeChannel(page);
-		user1Page = await browser.newPage({ storageState: Users.user1.state });
 		await page.goto(`/channel/${targetChannel}`);
 
+		user1Page = await browser.newPage({ storageState: Users.user1.state });
+		user1PoHomeChannel = new HomeChannel(user1Page);
+		await user1Page.goto(`/channel/${targetChannel}`);
+
 		await page.evaluate(() => {
 			Audio.prototype.play = ((fn) =>
 				function (this: HTMLAudioElement, ...args: unknown[]) {
@@ -53,12 +57,10 @@ test.describe.serial('Notification Sounds', () => {
 	});
 
 	test('should play default notification sounds', async ({ page }) => {
-		await user1Page.goto(`/channel/${targetChannel}`);
-		const user1PoHomeChannel = new HomeChannel(user1Page);
+		await poHomeChannel.content.waitForChannel();
 		await user1PoHomeChannel.content.waitForChannel();
 
 		await poHomeChannel.navbar.btnHome.click();
-
 		await user1PoHomeChannel.content.sendMessage(`Hello @${Users.admin.data.username} from User 1`);
 
 		await page.waitForTimeout(100); // wait for the sound to play
@@ -83,12 +85,10 @@ test.describe.serial('Notification Sounds', () => {
 		});
 
 		test('should play notification sound based on user preferences', async ({ page }) => {
-			await user1Page.goto(`/channel/${targetChannel}`);
-			const user1PoHomeChannel = new HomeChannel(user1Page);
+			await poHomeChannel.content.waitForChannel();
 			await user1PoHomeChannel.content.waitForChannel();
 
 			await poHomeChannel.navbar.btnHome.click();
-
 			await user1PoHomeChannel.content.sendMessage(`Hello @${Users.admin.data.username} from User 1`);
 
 			await page.waitForTimeout(100); // wait for the sound to play
@@ -111,12 +111,10 @@ test.describe.serial('Notification Sounds', () => {
 		});
 
 		test('should play custom room notification sound', async ({ page }) => {
-			await user1Page.goto(`/channel/${targetChannel}`);
-			const user1PoHomeChannel = new HomeChannel(user1Page);
+			await poHomeChannel.content.waitForChannel();
 			await user1PoHomeChannel.content.waitForChannel();
 
 			await poHomeChannel.navbar.btnHome.click();
-
 			await user1PoHomeChannel.content.sendMessage(`Hello @${Users.admin.data.username} from User 1`);
 
 			await page.waitForTimeout(100); // wait for the sound to play
@@ -139,12 +137,10 @@ test.describe.serial('Notification Sounds', () => {
 		});
 
 		test('should not play any notification sound', async ({ page }) => {
-			await user1Page.goto(`/channel/${targetChannel}`);
-			const user1PoHomeChannel = new HomeChannel(user1Page);
+			await poHomeChannel.content.waitForChannel();
 			await user1PoHomeChannel.content.waitForChannel();
 
 			await poHomeChannel.navbar.btnHome.click();
-
 			await user1PoHomeChannel.content.sendMessage(`Hello @${Users.admin.data.username} from User 1`);
 
 			await page.waitForTimeout(100); // wait for the sound to play