fix: Persist userId when updating a canned response (RocketChat#37277)

Author: yash-rajpal

.changeset/long-melons-float.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue where updating a private canned response wasn't being shown on canned-response contextualbar.

apps/meteor/ee/app/canned-responses/server/methods/saveCannedResponse.ts

@@ -99,7 +99,11 @@ export const saveCannedResponse = async (
 			});
 		}
 
-		result = await CannedResponse.updateCannedResponse(_id, { ...responseData, createdBy: cannedResponse.createdBy });
+		result = await CannedResponse.updateCannedResponse(_id, {
+			...responseData,
+			...(cannedResponse.scope === 'user' && { userId: cannedResponse.userId }),
+			createdBy: cannedResponse.createdBy,
+		});
 	} else {
 		const user = await Users.findOneById(userId);
 

apps/meteor/tests/end-to-end/api/livechat/15-canned-responses.ts

@@ -9,7 +9,7 @@ import { createAgent, createDepartment } from '../../../data/livechat/rooms';
 import { removeTag, saveTags } from '../../../data/livechat/tags';
 import { createMonitor, createUnit } from '../../../data/livechat/units';
 import { updatePermission, updateSetting } from '../../../data/permissions.helper';
-import { password } from '../../../data/user';
+import { password, adminUsername } from '../../../data/user';
 import { createUser, login } from '../../../data/users.helper';
 import { IS_EE } from '../../../e2e/config/constants';
 
@@ -245,6 +245,33 @@ import { IS_EE } from '../../../e2e/config/constants';
 			expect(getResult).to.have.property('success', true);
 			expect(getResult.cannedResponses).to.be.an('array').with.lengthOf(0);
 		});
+
+		it('should persist userId when updating a canned response', async () => {
+			const response = await createCannedResponse();
+
+			const {
+				body: { cannedResponses },
+			} = await request.get(api('canned-responses')).set(credentials).query({}).expect(200);
+
+			const targetCannedResponse = cannedResponses.find(
+				(cannedResponse: IOmnichannelCannedResponse) => cannedResponse.shortcut === response.shortcut,
+			);
+
+			const { body } = await request
+				.post(api('canned-responses'))
+				.set(credentials)
+				.send({ _id: targetCannedResponse._id, shortcut: `${targetCannedResponse.shortcut}-edited`, text: 'edited text', scope: 'user' })
+				.expect(200);
+			expect(body).to.have.property('success', true);
+
+			const { body: getResult } = await request
+				.get(api('canned-responses'))
+				.set(credentials)
+				.query({ shortcut: `${targetCannedResponse.shortcut}-edited` })
+				.expect(200);
+			expect(getResult).to.have.property('success', true);
+			expect(getResult.cannedResponses[0]).to.have.property('userId', adminUsername);
+		});
 	});
 
 	describe('[DELETE] canned-responses', () => {