fix: show disabled status when Presence_broadcast_disabled is enabled (RocketChat#40051)

Author: ricardogarim

.changeset/long-years-flow.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes user status indicator to show disabled state when presence broadcast is turned off

apps/meteor/client/lib/presence.spec.ts

@@ -0,0 +1,51 @@
+import { UserStatus } from '@rocket.chat/core-typings';
+
+import { Presence } from './presence';
+
+jest.mock('meteor/meteor', () => ({
+	Meteor: {
+		subscribe: jest.fn(),
+	},
+}));
+
+const mockGet = jest.fn();
+
+jest.mock('../../app/utils/client/lib/SDKClient', () => ({
+	sdk: {
+		rest: {
+			get: (...args: unknown[]) => mockGet(...args),
+		},
+	},
+}));
+
+describe('Presence fallback status', () => {
+	beforeEach(() => {
+		jest.clearAllMocks();
+		jest.useFakeTimers();
+		Presence.store.clear();
+	});
+
+	afterEach(() => {
+		jest.useRealTimers();
+	});
+
+	it('should use DISABLED as fallback when status is set to disabled', async () => {
+		mockGet.mockResolvedValue({ users: [] });
+		Presence.setStatus('disabled');
+
+		Presence.listen('user1', jest.fn());
+		await jest.advanceTimersByTimeAsync(500);
+
+		expect(Presence.store.get('user1')?.status).toBe(UserStatus.DISABLED);
+	});
+
+	it('should use OFFLINE as fallback when status is set to enabled', async () => {
+		mockGet.mockResolvedValue({ users: [] });
+		Presence.setStatus('enabled');
+
+		Presence.listen('user1', jest.fn());
+		await jest.advanceTimersByTimeAsync(500);
+
+		expect(Presence.store.get('user1')?.status).toBe(UserStatus.OFFLINE);
+	});
+});

apps/meteor/client/lib/presence.ts

@@ -73,6 +73,8 @@ const getPresence = ((): ((uid: UserPresence['_id']) => void) => {
 
 				const { users } = await sdk.rest.get('/v1/users.presence', params);
 
+				const fallbackStatus = status === 'disabled' ? UserStatus.DISABLED : UserStatus.OFFLINE;
+
 				users.forEach((user) => {
 					if (!store.has(user._id)) {
 						notify(user);
@@ -81,7 +83,7 @@ const getPresence = ((): ((uid: UserPresence['_id']) => void) => {
 				});
 
 				currentUids.forEach((uid) => {
-					notify({ _id: uid, status: UserStatus.OFFLINE });
+					notify({ _id: uid, status: fallbackStatus });
 				});
 
 				currentUids.clear();

apps/meteor/server/modules/listeners/listeners.module.ts

@@ -162,6 +162,10 @@ export class ListenersModule {
 				return;
 			}
 
+			if (settings.get('Presence_broadcast_disabled')) {
+				return;
+			}
+
 			notifications.notifyUserInThisInstance(_id, 'userData', {
 				type: 'updated',
 				id: _id,