refactor: Remove global references to Meteor (RocketChat#39316)

Author: tassoevan

apps/meteor/app/2fa/server/code/PasswordCheckFallback.ts

@@ -1,5 +1,6 @@
 import type { IUser } from '@rocket.chat/core-typings';
 import { Accounts } from 'meteor/accounts-base';
+import type { Meteor } from 'meteor/meteor';
 
 import type { ICodeCheck, IProcessInvalidCodeResult } from './ICodeCheck';
 import { settings } from '../../../settings/server';

apps/meteor/app/lib/server/functions/joinDefaultChannels.ts

@@ -1,4 +1,5 @@
 import { Users } from '@rocket.chat/models';
+import { Meteor } from 'meteor/meteor';
 
 import { addUserToDefaultChannels } from './addUserToDefaultChannels';
 

apps/meteor/app/livechat/imports/server/rest/inquiries.ts

@@ -18,6 +18,7 @@ import { getPaginationItems } from '../../../../api/server/helpers/getPagination
 import { findInquiries, findOneInquiryByRoomId } from '../../../server/api/lib/inquiries';
 import { returnRoomAsInquiry } from '../../../server/lib/rooms';
 import { takeInquiry } from '../../../server/lib/takeInquiry';
+import { Meteor } from 'meteor/meteor';
 
 API.v1.addRoute(
 	'livechat/inquiries.list',

apps/meteor/app/livechat/server/api/v1/room.ts

@@ -28,6 +28,7 @@ import {
 } from '@rocket.chat/rest-typings';
 import { isPOSTLivechatVisitorDepartmentTransferParams } from '@rocket.chat/rest-typings/src/v1/omnichannel';
 import { check } from 'meteor/check';
+import { Meteor } from 'meteor/meteor';
 
 import { callbacks } from '../../../../../server/lib/callbacks';
 import { i18n } from '../../../../../server/lib/i18n';
@@ -67,7 +68,7 @@ API.v1.addRoute(
 				agentId: Match.Maybe(String),
 			});
 
-			check(this.queryParams, extraCheckParams as any);
+			check(this.queryParams, extraCheckParams);
 
 			const { token, rid, agentId, ...extraParams } = this.queryParams;
 
@@ -291,7 +292,7 @@ API.v1.addRoute(
 			};
 
 			const room = await LivechatRooms.findOneById(this.bodyParams.roomId);
-			if (!room || room.t !== 'l') {
+			if (room?.t !== 'l') {
 				throw new Error('error-invalid-room');
 			}
 
@@ -358,7 +359,7 @@ const livechatVisitorDepartmentTransfer = API.v1.post(
 		}
 		const room = await LivechatRooms.findOneById(rid);
 
-		if (!room || room.t !== 'l') {
+		if (room?.t !== 'l') {
 			return API.v1.failure('error-invalid-room');
 		}
 
@@ -463,7 +464,7 @@ API.v1.addRoute(
 
 			const firstError = result.find((item) => item.status === 'rejected');
 			if (firstError) {
-				throw new Error((firstError as PromiseRejectedResult).reason.error);
+				throw new Error(firstError.reason.error);
 			}
 
 			await callbacks.run('livechat.saveInfo', await LivechatRooms.findOneById(roomData._id), {

apps/meteor/app/livechat/server/lib/rooms.ts

@@ -21,6 +21,7 @@ import {
 	Users,
 	ReadReceipts,
 } from '@rocket.chat/models';
+import { Meteor } from 'meteor/meteor';
 
 import { normalizeTransferredByData } from './Helper';
 import { QueueManager } from './QueueManager';

apps/meteor/app/livechat/server/lib/sendTranscript.ts

@@ -15,6 +15,7 @@ import { MessageTypes } from '@rocket.chat/message-types';
 import { LivechatRooms, Messages, Uploads, Users } from '@rocket.chat/models';
 import createDOMPurify from 'dompurify';
 import { JSDOM } from 'jsdom';
+import { Meteor } from 'meteor/meteor';
 import moment from 'moment-timezone';
 
 import { callbacks } from '../../../../server/lib/callbacks';

apps/meteor/app/slashcommands-leave/server/leave.ts

@@ -1,6 +1,7 @@
 import { api } from '@rocket.chat/core-services';
 import type { SlashCommandCallbackParams } from '@rocket.chat/core-typings';
 import { Users } from '@rocket.chat/models';
+import { Meteor } from 'meteor/meteor';
 
 import { i18n } from '../../../server/lib/i18n';
 import { leaveRoomMethod } from '../../lib/server/methods/leaveRoom';

apps/meteor/client/lib/2fa/overrideLoginMethod.ts

@@ -1,4 +1,5 @@
 import { Accounts } from 'meteor/accounts-base';
+import type { Meteor } from 'meteor/meteor';
 
 import { isTotpInvalidError, isTotpMaxAttemptsError, isTotpRequiredError } from './utils';
 

apps/meteor/client/lib/2fa/utils.ts

@@ -1,3 +1,5 @@
+import type { Meteor } from 'meteor/meteor';
+
 export const isTotpRequiredError = (
 	error: unknown,
 ): error is Meteor.Error & ({ error: 'totp-required' } | { errorType: 'totp-required' }) =>

apps/meteor/client/meteor/minimongo/DiffSequence.ts

@@ -1,3 +1,5 @@
+import { Meteor } from 'meteor/meteor';
+
 import type { IdMap } from './IdMap';
 import { clone, hasOwn, equals } from './common';
 import type { Observer, OrderedObserver, UnorderedObserver } from './observers';