fix: Leave room action available for users without subscription (RocketChat#37477)

Author: dougfabris

.changeset/modern-onions-repair.md

@@ -0,0 +1,6 @@
+---
+'@rocket.chat/mock-providers': patch
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue where leave room action is available for users without subscription

apps/meteor/client/views/room/contextualBar/Info/hooks/actions/useRoomLeave.spec.ts

@@ -0,0 +1,40 @@
+import { mockAppRoot } from '@rocket.chat/mock-providers';
+import type { SubscriptionWithRoom } from '@rocket.chat/ui-contexts';
+import { renderHook } from '@testing-library/react';
+
+import { useRoomLeave } from './useRoomLeave';
+import { createFakeRoom, createFakeSubscription } from '../../../../../../../tests/mocks/data';
+
+const mockRoom = createFakeRoom({ _id: 'room1', t: 'c', name: 'room1', fname: 'Room 1' });
+const mockSubscription = createFakeSubscription({ name: 'room1', t: 'c', disableNotifications: false, rid: 'room1' });
+
+jest.mock('../../../../../../../app/ui-utils/client', () => ({
+	LegacyRoomManager: {
+		close: jest.fn(),
+	},
+}));
+
+jest.mock('../../../../../../../client/lib/rooms/roomCoordinator', () => ({
+	roomCoordinator: {
+		getRoomDirectives: () => ({
+			getUiText: () => 'leaveWarning',
+		}),
+	},
+}));
+
+it('should return leave function if user has subscription', () => {
+	const wrapper = mockAppRoot()
+		.withPermission('leave-c')
+		.withSubscriptions([{ ...mockSubscription, rid: 'room1' }] as unknown as SubscriptionWithRoom[])
+		.build();
+
+	const { result } = renderHook(() => useRoomLeave(mockRoom), { wrapper });
+	expect(typeof result.current).toBe('function');
+});
+
+it('should return null if user does not have subscription', () => {
+	const wrapper = mockAppRoot().withPermission('leave-c').build();
+
+	const { result } = renderHook(() => useRoomLeave(mockRoom), { wrapper });
+	expect(result.current).toBeNull();
+});

apps/meteor/client/views/room/contextualBar/Info/hooks/actions/useRoomLeave.tsx

@@ -1,22 +1,23 @@
 import type { IRoom } from '@rocket.chat/core-typings';
 import { useEffectEvent } from '@rocket.chat/fuselage-hooks';
 import type { TranslationKey } from '@rocket.chat/ui-contexts';
-import { useRouter, useSetModal, useToastMessageDispatch, useMethod, useTranslation, usePermission } from '@rocket.chat/ui-contexts';
+import { useRouter, useSetModal, useToastMessageDispatch, useMethod, usePermission, useUserSubscription } from '@rocket.chat/ui-contexts';
+import { useTranslation } from 'react-i18next';
 
 import { LegacyRoomManager } from '../../../../../../../app/ui-utils/client';
 import { UiTextContext } from '../../../../../../../definition/IRoomTypeConfig';
 import WarningModal from '../../../../../../components/WarningModal';
 import { roomCoordinator } from '../../../../../../lib/rooms/roomCoordinator';
 
-// TODO implement joined
-export const useRoomLeave = (room: IRoom, joined = true) => {
-	const t = useTranslation();
+export const useRoomLeave = (room: IRoom) => {
+	const { t } = useTranslation();
+	const subscription = useUserSubscription(room._id);
 	const setModal = useSetModal();
 	const dispatchToastMessage = useToastMessageDispatch();
 	const leaveRoom = useMethod('leaveRoom');
 	const router = useRouter();
 
-	const canLeave = usePermission(room.t === 'c' ? 'leave-c' : 'leave-p') && room.cl !== false && joined;
+	const canLeave = usePermission(room.t === 'c' ? 'leave-c' : 'leave-p') && room.cl !== false && Boolean(subscription);
 
 	const handleLeave = useEffectEvent(() => {
 		const leaveAction = async () => {

packages/mock-providers/src/MockedAppRootBuilder.tsx

@@ -150,7 +150,7 @@ export class MockedAppRootBuilder {
 		queryPreference: () => [() => () => undefined, () => undefined],
 		queryRoom: () => [() => () => undefined, () => this.room],
 		querySubscription: () => [() => () => undefined, () => this.subscriptions as unknown as ISubscription],
-		querySubscriptions: () => [() => () => undefined, () => this.subscriptions], // apply query and option
+		querySubscriptions: () => [() => () => undefined, () => this.subscriptions ?? []], // apply query and option
 		user: null,
 		userId: undefined,
 	};
@@ -203,7 +203,7 @@ export class MockedAppRootBuilder {
 
 	private room: IRoom | undefined = undefined;
 
-	private subscriptions: SubscriptionWithRoom[] = [];
+	private subscriptions: SubscriptionWithRoom[] | undefined = undefined;
 
 	private modal: ModalContextValue = {
 		currentModal: { component: null },