Commit 7739c51
authored
Revert "login: handle redirect properly for Google OAuth (tldraw#7117)" (tldraw#7189)
This reverts commit 38d8ff5.
was causing new signups to fail 😢
### Change type
- [ ] `bugfix`
- [ ] `improvement`
- [ ] `feature`
- [ ] `api`
- [x] `other`
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Replaces custom Google OAuth sign-in handler with Clerk Elements
`Connection` inside `SignIn.Root` and removes the related redirect
logic; deletes the obsolete TODO file.
>
> - **Auth UI
(`apps/dotcom/client/src/tla/components/dialogs/TlaSignInDialog.tsx`)**:
> - Replace custom Google OAuth handler and redirect logic with Clerk
Elements:
> - Add `@clerk/elements/common` and `@clerk/elements/sign-in` imports.
> - Use `<SignIn.Root>` and `<Clerk.Connection name="google" asChild>`
for the Google button with `<Clerk.Icon>`.
> - Remove bespoke `handleGoogleSignIn` function and routing-based
redirect URL construction.
> - **Chore**:
> - Delete `TlaSignInDialog.todo.md`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
21db85a. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent b0e0801 commit 7739c51
2 files changed
Lines changed: 18 additions & 49 deletions
Lines changed: 0 additions & 8 deletions
This file was deleted.
Lines changed: 18 additions & 41 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
2 | 4 | | |
3 | 5 | | |
4 | 6 | | |
| |||
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
12 | | - | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
113 | 114 | | |
114 | 115 | | |
115 | 116 | | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | 117 | | |
143 | 118 | | |
144 | 119 | | |
| |||
226 | 201 | | |
227 | 202 | | |
228 | 203 | | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
243 | 220 | | |
244 | 221 | | |
245 | 222 | | |
| |||
0 commit comments