Commit 83f51f6
authored
refactor(dotcom): remove the groups_frontend flag (tldraw#9411)
In order to finish the workspaces cleanup, this PR completely removes
the `groups_frontend` feature flag and its rollout machinery. Workspaces
is fully shipped: `groups_backend` (the data migration) is at 100% and
granted to every user on signup, and `groups_frontend` (the UI flag)
recently reached 100%. With tldraw#9405 removing the last UI fork that read
the flag, nothing depends on it anymore. Relates to tldraw#8859.
**Preview deploy:** https://pr-9411-preview-deploy.tldraw.com/ — verify
the admin page (groups-enrollment section + rollout slider gone, other
sections intact) and that signup / invite-acceptance still work. No flag
is needed; every account already has `groups_backend`.
**Stacked on tldraw#9405** — that PR's branch is this one's base, so the diff
below is only the flag removal. Merge tldraw#9405 first; keeping this as a
draft until then.
- Drop the `groups_frontend` member from the `TlaFlags` enum.
- Delete the workspaces UI rollout utility (`workspacesUiRollout.ts`)
and its tests.
- Remove the admin groups-enrollment section and the rollout-percentage
slider, plus the `enroll_groups` / `unenroll_groups` / rollout-SSE
routes and the `admin_enrollInGroups` / `admin_unenrollFromGroups`
durable-object methods.
- Stop granting `groups_frontend` on user creation and invite
acceptance.
- Update the flag-parsing tests and the e2e fixture to drop the retired
flag.
The backend migration tooling is untouched: `groups_backend` stays in
the enum, and the `admin_migrateToGroups` route/method remain for
manually migrating a user's data if needed.
No data migration is required. The `user.flags` column is free-form text
(not enum-validated), so leftover `groups_frontend` tokens on existing
rows are simply ignored once nothing reads them.
### Change type
- [x] `other` (internal refactor, no user-facing change)
### Test plan
1. On the preview deploy, sign in as a normal user — confirm the app
loads and the workspaces sidebar works (file list, switcher, "Move to",
drag).
2. Accept a workspace invite — confirm it still works (the
`groups_backend` check remains; only the redundant `groups_frontend`
grant is gone).
3. Open the admin page — confirm it loads with the groups-enrollment
section and rollout slider gone, and the remaining sections (feature
flags, welcome template, delete user) intact.
- [x] Unit tests
- [ ] End to end tests
### Code changes
| Section | LOC change |
| --------- | ---------- |
| Core code | +2 / -2 |
| Tests | +4 / -152 |
| Apps | +4 / -929 |1 parent 4f92f5a commit 83f51f6
11 files changed
Lines changed: 10 additions & 1083 deletions
File tree
- apps/dotcom
- client
- e2e
- fixtures
- tests/smoke
- src/pages
- sync-worker/src
- routes/tla
- utils
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | 84 | | |
114 | 85 | | |
115 | | - | |
116 | 86 | | |
117 | 87 | | |
118 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
0 commit comments