Conversation
When I was working on the workflows starter, I found myself needing to store a lot of state in atoms. This includes: * The current exectution * Which ports on which shapes should be highlighted when dragging a connection * Whether the on-canvas component picker was visible, and which shape it should be attached to All of this state should really belong to a specific `Editor` instance. It's referencing data from that instance. If I was building a full app and navigated from one workflow to another, I would want all the state to be cleared due to the editor getting re-created. It's possible to get this sort of functionality by using a weak map from editors to atoms, but it takes a fair bit of management. This diff adds an `EditorAtom` helper which handles the weak-map juggling. The interface is similar to that of `Editor`, but each method takes an `editor` for scoping. ### Change type - [x] `api` ### Release notes ### API Changes - Added `EditorAtom`, a helper for storing editor UI state in an `Atom`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )