Conversation
For workflow builder, we want a vertical toolbar. I'm backporting it to the SDK because it's a common enough request (#6532), but in the process i got super confused by two things: * We have a `tlui-toolbar` classname and a `TldrawUiToolbar` component. These are completely unrelated. * We have some `tlui-buttons` classnames that are _almost always_ used with `TldrawUiToolbar`, and sometimes contain buttons as the name would suggest. So this diff tweaks those. `tlui-toolbar` (used for the main actual toolbar at the bottom of the screen) and co are now `tlui-main-toolbar`. `tlui-buttons` has been replaced with some components that have the same effect: `TldrawUiRow` and `TldrawUiGrid`. These are now used by `TldrawUiToolbar` depending on the `orientation` prop it gets passed. I wanted to use components instead of classnames for these because if you're customizing our UI by copy-pasting chunks of it, random CSS classnames are even less well documented than components like these. I also wanted names that reflected the way these were used a bit better (ie often not with buttons). ### Change type - [x] `api` ### Release notes ### API Changes - Added `TldrawUiRow` and `TldrawUiGrid` layout classes. - The `tlui-buttons__horizontal` and `tlui-buttons__grid` class names have been replaced by `tlui-row` and `tlui-grid` - The `tlui-toolbar` classnames have been renamed to `tlui-main-toolbar`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )