Conversation
This PR updates the number of connections in the readme (from 30 to 50) ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [X] `other`
This PR flattens the color theme object and introduces a new helper, `getColorValue`, that helps pull a color from the theme. This should actually make #6462 (and other color-related work) much more practical. ## Flattening `DefaultColorThemePalette` This PR flattens the `DefaultColorThemePalette`, removing the nested properties and renaming them instead. ```ts theme.black.frame.fill ``` Becomes ```ts theme.black.frameFill ``` ## `getColorValue` This pull request standardizes and simplifies how color values are accessed throughout the codebase by introducing and consistently using the new `getColorValue` utility function. This change replaces direct property access on the `theme` object with calls to `getColorValue`, improving maintainability and reducing the risk of errors due to inconsistent color property keys. The update affects a wide range of shape utilities, rendering logic, and example components. ```ts theme.black.frameFill ``` Becomes ```ts getColorValue(theme, 'black', 'frameFill') ``` **Refactoring color value access:** * Replaced direct `theme` property access with `getColorValue` for all shape utilities, including `ArrowShapeUtil`, `DrawShapeUtil`, `GeoShapeUtil`, `FrameShapeUtil`, `HighlightShapeUtil`, `LineShapeUtil`, and `NoteShapeUtil`, ensuring consistent and safer color retrieval. * Updated SVG export logic to use `getColorValue` for determining frame background color. * Added `getColorValue` to imports in all affected files to support the new color access pattern. * Updated example components (`CardShapeUtil`, `CustomRenderer`, `ShapeWithTldrawStylesExample`, `SpeechBubbleUtil`) to use `getColorValue` instead of direct theme property access for colors in rendering logic. These changes collectively improve code consistency, make color logic more robust, and pave the way for easier updates or extensions to color theming in the future. ### Change type - [ ] `bugfix` - [x] `improvement` - [ ] `feature` - [x] `api` - [ ] `other` ### API changes - Changes to the `DefaultColorThemePalette` object. Any color customization may need to be refactored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )