Conversation
css variables cascade down through the tree. we've had reports in the past of people having issues because our css variable names, which are fairly generic (`--space-3`, `--color-warning`) clash with those from customers design systems. this diff takes advantage of the coming 4.0 to rename all our variables to namespace them with `--tl-`, like we do with our classnames. ### Change type - [x] `api` ### Release notes - **BREAKING:** all of tldraw's css variables now start with `--tl`. e.g. `--color-background` is now `--tl-color-background`, `--space-4` is now `--tl-space-4`, etc. Names which already started with `--tl-` remain the same.
Add cookie consent for logged out users. 1. We store this in local storage. 2. If the user then logs in we sync it with the user's signed in options, so that they have a consistent experience when logged in or logged out. 3. If a logged in user changes their preference we also update it in local storage so that it's the same if they log out. 4. For logged out users we also show an additional entry in the main menu, which allows them to change their cookie preferences. 5. Decided to go with a more generic storage of the cookie consent, which can allow us to add consent for cookies with other purposes (like marketing,...) We'll adjust the appearance of the consent dialog in a follow up PR. ### Change type - [x] `improvement`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )