Conversation
Reduced margin-bottom and added margin-right for the cookie dialog. Updated cookieConsentWrapper to align to the right edge instead of using a variable offset. Describe what your pull request does. If you can, add GIFs or images showing the before and after of your change. ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other`
This re-does this #6580 without conflicts ### Change type - [x] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [ ] `other` ### Test plan 1. Create a shape... 2. - [ ] Unit tests - [ ] End to end tests #### API changes Added the delayDuration option to tooltips to let you override the delay for a single tooltip.
This change adds drag icons when logged in. ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other`
Adds an API example showing how to use the editor's `zoomToBounds` function. re: [this linear issue](https://linear.app/tldraw/issue/ENG-3171/example-request-zooming-to-bounds) ### Change type - [ ] `bugfix` - [ ] `improvement` - [x] `feature` - [ ] `api` - [ ] `other` --------- Co-authored-by: Lu Wilson <l2wilson94@gmail.com>
When accel key is held, only the first / top-most erasing shape will be erased. ### Change type - [x] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [ ] `other` ### Test plan 1. Create overlapping shapes 2. Click while holding cmd to erase only the top shape - [x] Unit tests ### Release notes - Feature: hold command or control while erasing to erase only the first shape that you began erasing. Useful for erasing overlapping shapes!
This PR fixes dragging interactions when using multiple tldraw components on the same page. eg: [Inset editors with fixed sizes](https://examples-canary.tldraw.com/inline) and [Common practices with inset editors](https://examples-canary.tldraw.com/inline-behavior) The bug happened because we're now handling pointer move events on a document basis, not an editor-by-editor basis. This meant that different tldraw editors were killing the pointer move event, preventing other editors from handling it. This PR fixes the bug by *no longer killing the event*. If we do need to kill the event, perhaps we could kill the event on an editor-by-editor basis by tracking this as a map instead of a boolean or something. ### Change type - [x] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [ ] `other` ### Test plan 1. Try the "Inset editor (fixed sizes)" and "Inset editor (common practices)" examples. 2. Try drawing in multiple editors. Make sure you can draw in more than just one of them. - [ ] Unit tests - [ ] End to end tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )