Conversation
This PR pulls across a fix from fairydraw into the agent starter. ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other` ### Test plan 1. Create a shape... 2. - [ ] Unit tests - [ ] End to end tests ### Release notes - Agent starter: Fixed a bug where shape indices could get set to the same value. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Use the highest parent index for new shapes instead of a hardcoded value across all shape converters to avoid index collisions. > > - **templates/agent/shared/format/convertSimpleShapeToTldrawShape.ts**: > - **Index assignment**: When a shape's `index` is absent, use `editor.getHighestIndexForParent(editor.getCurrentPageId())` instead of the hardcoded `'a1'` for: > - `text`, `line`, `arrow`, `geo`, `note`, `draw`, and `unknown` shapes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d31e468. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
tiptap: fix focus issue when editor not mounted ### Change type - [x] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [ ] `other` ### Release notes - tiptap: fix minor focus issue if editor isn't mounted yet <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Guard Tiptap toolbar actions and active-state checks when the editor view isn't mounted to prevent focus errors. > > - **Rich Text Toolbar (`DefaultRichTextToolbarContent.tsx`)**: > - Add guard to avoid invoking Tiptap operations when `textEditor.view` is undefined. > - Compute `isActive` defensively using `textEditor.view ? ... : false` to prevent access before mount. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 299507f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )