Conversation
doing fine grained diffs on the tip tap documents was no bueno ### Change type - [x] `other` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Treat `props` and `meta` as nested patches, while defaulting non-string/non-array object fields to full `put` when changed; update diffing internals accordingly. > > - **Diffing behavior**: > - Treat `props` and `meta` as nested keys for patching via `diffObject`. > - For other object fields, emit `put` when changed unless values are arrays or strings (which still diff/append). > - Maintain fine-grained handling for arrays (`diffArray`) and strings (append optimization). > - **API/Internal changes**: > - `diffRecord` now calls `diffObject(prev, next, new Set(['props','meta']), legacyAppendMode)`. > - `diffObject` signature includes `nestedKeys` and uses shallow equality to choose between nested `diffValue` vs `put`. > - Recursive calls to `diffObject` pass `undefined` for `nestedKeys` to limit deep nesting. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8329710. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )