Conversation
adds ToS/privacy policy to sign in dialog <img width="493" height="569" alt="Screenshot 2025-11-14 at 09 43 40" src="https://github.com/user-attachments/assets/fb9fee4c-be3e-4802-9ce4-4917b3488e78" /> ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds Terms of Use and Privacy Policy links to the sign-in dialog with supporting styles and i18n entries. > > - **Frontend (sign-in)**: > - Add links to `Terms of Use` and `Privacy Policy` in `src/tla/components/dialogs/TlaSignInDialog.tsx` below the email submit button. > - Apply `className` to `#clerk-captcha` and style via `.clerkCaptcha` in `auth.module.css`. > - Add `.authTermsOfUse` styles for the legal links in `src/tla/components/dialogs/auth.module.css`. > - **i18n**: > - Add translation keys for `"Terms of Use"` and `"Privacy Policy"` in `public/tla/locales/en.json` and `locales-compiled/en.json`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c2db464. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
@MitjaBezensek noticed that for Google sign-in we weren't redirecting properly. We have to go closer to the metal to make that work, took a while to figure out this magic incantation ✨ 🪄 ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Replaces Clerk Elements Google sign-in with a custom button that initiates Clerk OAuth and redirects via externalVerificationRedirectURL. > > - **Auth (TlaSignInDialog.tsx)**: > - **Google OAuth**: > - Add `handleGoogleSignIn` to initiate `signIn.create({ strategy: 'oauth_google', redirectUrl })` and redirect using `firstFactorVerification.externalVerificationRedirectURL`. > - Replace Clerk Elements UI (`SignIn.Root/Step`, `Clerk.Connection`) with a custom `TlaCtaButton` and static Google icon. > - Remove unused Clerk Elements imports. > - **Email sign-in**: Existing email flow retained; no functional changes shown. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit becd5df. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
* Opt in the user to the `groups_frontend` flag whey they accept a group invite. * Fix infinite navigations. * Add blank title to the dialog to avoid the missing title error. ### Change type - [x] `other` # <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Automatically sets the `groups_frontend` flag for users when they accept a group invite. > > - **Backend** > - `apps/dotcom/sync-worker/src/routes/tla/acceptInvite.ts`: > - On invite acceptance, if user lacks `groups_frontend`, append it to `user.flags` within the transaction. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7d2993d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
ugh, didn't notice the scrollbar (esp. with mac os hidden scrollbars) ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refines sign-in dialog layout by zero-padding the dialog body, wrapping content in an inner container, and only applying CAPTCHA spacing when rendered. > > - **UI/Layout**: > - Update `apps/dotcom/client/src/tla/components/dialogs/TlaSignInDialog.tsx`: > - Apply `styles.authDialogBody` to `TldrawUiDialogBody` and wrap `innerContent` in a `div` with `styles.authBody`. > - Update `apps/dotcom/client/src/tla/components/dialogs/auth.module.css`: > - Add `.` `authDialogBody` with zero padding. > - Replace `.clerkCaptcha` rule with `.clerkCaptcha:not(:empty)` to add padding and adjust top margin only when CAPTCHA renders. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 19010a1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
…gs (#7128) we usually get translations same day but the login stuff went out before translations were ready so we didn't notice this issue until now. ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Ensure untranslated strings fall back to English by merging fetched locale messages with the English bundle. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 59298bc. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )