Conversation
Add some basic group e2e tests. There's a ton more we could add, but went for the most basic ones for now as they do tend to be on the slow side. ### Change type - [x] `other` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds end-to-end tests and fixtures for groups (CRUD, reorder, file ops, sharing) with supporting test utilities and minor test-id/DO route adjustments. > > - **E2E Tests**: > - Add `tests/groups.spec.ts` covering group create/rename/delete, expand/collapse persistence, reordering via drag, file create/move/drag/pin/unpin/duplicate/delete, move-to-home, and sharing/invitation flows with cross-user propagation. > - **Fixtures/Helpers**: > - New `GroupInviteDialog` fixture; register in `tla-test.ts` and `helpers.ts`. > - Extend `Sidebar` fixture with group operations, file operations within groups, drag-and-drop utilities, and invite-link copy methods; add `createGroupButton` selector. > - `Database` fixture: add `enableGroupsFrontend()` and simplify cleanup to hit `prepare-for-test` without legacy header. > - Remove init-mode code from `HomePage`. > - **App UI**: > - Change sidebar create-group button test id to `tla-create-group` in `TlaSidebar.tsx`. > - **Sync Worker (test utilities)**: > - Simplify `__test__prepareForTest`: always set `groups_backend`, clear all user groups, and recreate home group; update `/app/__test__/user/:userId/prepare-for-test` route accordingly. > - **Cleanup**: > - Remove `run-both-modes.sh` and `init-mode-verification.spec.ts`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 18c142a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )