Conversation
Follow-up to #8210. Adds inline comments throughout the geometry primitives explaining what the expanded/inlined scalar math was originally doing in terms of the higher-level Vec API calls it replaced. This makes it more maintainable going forward. Made-with: Cursor you're fast to the draw(heh) Steve, made this PR - didn't have time to comment on it ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Mostly adds explanatory comments around previously inlined scalar geometry math, but also makes small behavioral tweaks in `Arc2d.nearestPoint` and `pointInPolygon` that could affect rare edge/endpoint hit-testing cases. > > **Overview** > Adds inline documentation across geometry hot paths (`Vec`, `Circle2d`, `Arc2d`, `Edge2d`, `Polyline2d`, `intersect`) to explain what the expanded scalar math corresponds to in terms of higher-level `Vec` operations, and why allocations/sqrt calls are being avoided. > > Also makes a couple of small logic adjustments while annotating: `Arc2d.nearestPoint` no longer re-checks distances to endpoints when `t` is already in-range, and `pointInPolygon` drops the expensive exact-on-edge distance-equality check in favor of the winding-number test plus exact vertex match. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 47346ea. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )