[pull] main from tldraw:main#464
Merged
Merged
Conversation
…8354) The `sanitizeVariables()` connection-string regex included `https?` alongside database protocols, causing all HTTP/HTTPS URLs (GitHub PR links, worker URLs) to be redacted to `https://***` in Discord deploy notifications. This PR removes `https?` from that regex so only actual database connection strings are sanitized. Actual secrets (`postgres://` connection strings) are still covered by both the `KEY=VALUE` regex and the remaining connection-string protocols. ### Change type - [x] `bugfix` ### Test plan 1. Deploy a change and verify Discord notification contains clickable GitHub PR link ### Release notes - Fix Discord deploy notifications redacting GitHub links ### Code changes | Section | LOC change | | -------------- | ---------- | | Config/tooling | +1 / -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )