Conversation
In order to stay current with the hotkeys-js library and pick up improvements to keyboard layout handling, this PR updates hotkeys-js from ^3.13.9 to ^4.0.2. The v4 release includes a TypeScript rewrite, layout-independent hotkey handling improvements, and a fix for stuck keys on fullscreen changes. No code changes were needed — the API is backwards compatible. Relates to #8250 ### Change type - [x] `improvement` ### Test plan - All existing tests pass (2186 in tldraw package) - Typecheck passes with no errors - [x] Unit tests ### Release notes - Update hotkeys-js keyboard shortcut library from v3 to v4. ### Code changes | Section | LOC change | | -------------- | ---------- | | Core code | +1 / -1 | | Config/tooling | +5 / -5 |
#8371) In order to keep the documentation accurate after the consolidation of editor configuration into the unified `options` prop, this PR removes the deprecated `cameraOptions`, `textOptions`, and `deepLinks` entries from the props table and updates all rich-text code examples to use `options.text` instead of the old `textOptions` prop. Relates to #7607 ### Change type - [x] `improvement` ### Test plan 1. Visit the [options docs page](http://localhost:3001/sdk-features/options) and verify `cameraOptions`, `textOptions`, and `deepLinks` are no longer listed in the editor setup props table 2. Visit the [rich text docs page](http://localhost:3001/sdk-features/rich-text) and verify code examples use `options.text` instead of `textOptions` ### Release notes - Update SDK documentation to use the unified `options` prop instead of deprecated `cameraOptions`, `textOptions`, and `deepLinks` props ### Code changes | Section | LOC change | | ------------- | ---------- | | Documentation | +31 / -28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )