[pull] main from tldraw:main#494
Merged
Merged
Conversation
Closes #8456 In order to fix the TypeScript signature mismatch where `ShapeUtil` base class methods declare a `shape` parameter that overrides omit, this PR cleans up both sides: the base class param names are tidied (removing unnecessary underscore prefixes on `canBind` and `canReceiveNewChildrenOfType`), and override implementations that had unused `_shape` params from an earlier pass now omit them entirely — TypeScript allows omitting trailing parameters in overrides, so they only need to appear in implementations that actually reference the shape. ### Change type - [x] `bugfix` ### Test plan 1. Create image, video, note, text, geo, arrow, frame, embed, and line shapes 2. Verify resize, crop, and other interactions work as before - [ ] Unit tests - [ ] End to end tests ### Release notes - Fixed ShapeUtil method signatures so overrides that need the `shape` parameter can declare it without TypeScript errors. ### API changes Changes to `packages/editor/api-report.api.md`: - `ShapeUtil.canBind(_opts)` → `ShapeUtil.canBind(opts)` — removed underscore prefix - `ShapeUtil.canReceiveNewChildrenOfType(shape, _type)` → `ShapeUtil.canReceiveNewChildrenOfType(shape, type)` — removed underscore prefix ### Code changes | Section | LOC change | | --------------- | ---------- | | Core code | +2 / -2 | | Automated files | +2 / -2 | | Documentation | +4 / -4 | | Templates | +3 / -3 | --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )